Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls with arrow keys operation in the toolbar? #1283

Open
JAWS-test opened this issue Dec 10, 2019 · 2 comments
Open

Controls with arrow keys operation in the toolbar? #1283

JAWS-test opened this issue Dec 10, 2019 · 2 comments

Comments

@JAWS-test
Copy link

The APG toolbar chapter says

Avoid including controls whose operation requires the pair of arrow keys used for toolbar navigation. If unavoidable, include only one such control and make it the last element in the toolbar. For example, in a horizontal toolbar, a textbox could be included as the last element

I suggest to remove the second and third sentence, because even at the end of the toolbar an input field causes that the other elements are not reached anymore, if the input field gets the focus or that within the input field cannot be navigated with the arrow keys

@smhigley
Copy link
Contributor

smhigley commented Jan 2, 2020

I agree, it doesn't make sense to me to allow controls to hijack the toolbar's arrow key interaction. In the same way that the editable data grid uses Enter/Escape to surface the text input, it would make more sense to require toolbar controls that use the same arrow keys to be behind similar enter/escape or disclosure patterns.

@veselints
Copy link

Hi there!

As we have a really extensive Toolbar, there are scenarios in which it contains Textbox and Combobox controls that follow their own keyboard navigation patterns. As a result, they do not allow Left/Right arrow keys to be used by the Toolbar.

In my opinion, the statement "Avoid including controls whose operation requires the pair of arrow keys used for toolbar navigation." does not give much value. We do our best to "avoid" the use of such controls, but at the end of the day, we have to embed them in the Toolbar. They are not forbidden ("avoid" is different than "must not"), so their usage should be clarified.

What keyboard navigation pattern should we follow then? Do we wrap them, similarly to Grid cells with inputs in them as @smhigley suggested? Should be the Toolbar navigation pattern completely revised, so that it also covers the usage of those controls? Or the above sentence should be revised to "Controls whose operation requires the pair of arrow keys used for toolbar navigation are not allowed in the Toolbar."?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants