Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox quirk with date picker dialog #1311

Closed
scottaohara opened this issue Jan 27, 2020 · 2 comments · Fixed by #1313
Closed

firefox quirk with date picker dialog #1311

scottaohara opened this issue Jan 27, 2020 · 2 comments · Fixed by #1313
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Projects
Date Picker Pattern and Examples Deve...
Milestone
1.2 Release 1

Comments

@scottaohara
Copy link
Member

scottaohara commented Jan 27, 2020 •
edited
Loading

reviewing the date picker dialog with Firefox, if i try to select a date, or attempt to activate the Cancel or OK buttons by using the Space key, the dialog quickly closes and then reopens. I would expect the dialog to not reopen.

This issue does not occur when pressing the Enter key. It also does not occur when using Chrome.
@mcking65
Copy link
Contributor

I can repro this in the version on TR. However, I cannot reproduce it in the current editor's draft:
https://w3c.github.io/aria-practices/examples/dialog-modal/datepicker-dialog.html

Scott, can you repro in the editor's draft?

@scottaohara
Copy link
Member Author

@mcking65 in the link you provided the cancel and ok buttons work correctly, but the buttons to select a day of the week still have the issue.

Looks like it could be corrected by just having a single click event on the days, rather than a mousedown and keydown events.

@smhigley smhigley mentioned this issue Jan 27, 2020
Merged
3 tasks
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Jan 28, 2020
@mcking65 mcking65 moved this from Next Steps to In progress in Date Picker Pattern and Examples Development Project Jan 28, 2020
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Jan 28, 2020
Date Picker Pattern and Examples Development Project automation moved this from In progress to Complete Feb 6, 2020
mcking65 added a commit that referenced this issue Feb 6, 2020
@smhigley @mcking65
Date Picker Dialog: remove mixed click and enter/space key listeners …
d7ea476 
…for buttons (pull #1313)

Resolves #1311:
When using Firefox, activating a date button in the calendar grid was causing the dialog to close and re-open instead of choosing the date.
This commit resolves the issue with changes to event listeners.

Co-authored-by: Matt King <a11yThinker@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Projects
Date Picker Pattern and Examples Deve...
  
Complete
Milestone
1.2 Release 1
Development

Successfully merging a pull request may close this issue.

Date Picker Dialog: Remove mixed click and enter/space listeners for buttons w3c/aria-practices
2 participants
@scottaohara @mcking65