Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landmark Example update to make HTML technique first view #1391

Closed
jongund opened this issue Apr 27, 2020 · 3 comments · Fixed by #1441
Closed

Landmark Example update to make HTML technique first view #1391

jongund opened this issue Apr 27, 2020 · 3 comments · Fixed by #1441
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Milestone

Comments

@jongund
Copy link
Contributor

jongund commented Apr 27, 2020

In the ARIA landmark example, we should consider making the HTML technique the default technique instead of the ARIA technique.

Main Landmark Example

@carmacleod
Copy link
Contributor

I agree.
So, for each landmark type, the "HTML Techniques" tab should be the leftmost (i.e. the "first") tab in the tablist, and it should be the selected tab.

@jongund
Copy link
Contributor Author

jongund commented Apr 27, 2020

@carmacleod

Yes, it would be the first tab and it would be selected.

@guyhickling
Copy link

Also, given that the <main> element is the appropriate method for HTML5, and the div/role method is really only appropriate for HTML4/XHTML pages, would it be possible to add a sentence to this effect at the top of the tab panel for the ARIA method? Changing the order will certainly help, but saying it in text will explain it clearly.

@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern labels Jul 19, 2020
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Jul 19, 2020
mcking65 added a commit that referenced this issue Jul 19, 2020
…(pull #1441)

Resolves issue #1391 by revising the landmark region example pages to select and load the HTML techniques by default on page load.

Also corrects spelling of VoiceOver and improves alt text for some images.

Co-authored-by: Matt King <a11yThinker@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants