Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landmark label text is ambiguous #453

Closed
ZoeBijl opened this issue Sep 11, 2017 · 4 comments
Closed

Landmark label text is ambiguous #453

ZoeBijl opened this issue Sep 11, 2017 · 4 comments
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Practice Page Related to a page within the practices section of the APG

Comments

@ZoeBijl
Copy link
Contributor

ZoeBijl commented Sep 11, 2017

Step 3 under General Principles of Landmark Design reads:

If a specific landmark role is used more than once on a web page, it should have a unique label.

What does this mean? Does it mean that all instances excluding the initial one need a label? Does it mean all instances need a label?

To me it makes sense that all instances have a label.

@ZoeBijl ZoeBijl added the editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. label Sep 11, 2017
@jkva
Copy link

jkva commented Sep 11, 2017

Agreed. Once more than one landmark of the same role exists on a page, there can be no ambiguity and unique labels become necessary. Assigning implicit meaning to one unlabelled landmark role in a set of labelled identical roles smells of bad design.

@mcking65 mcking65 added the Practice Page Related to a page within the practices section of the APG label Dec 8, 2017
@mcking65 mcking65 added this to the 1.1 APG Release 2 milestone Dec 8, 2017
jnurthen added a commit that referenced this issue May 21, 2018
@mcking65
Copy link
Contributor

mcking65 commented Jun 4, 2018

There are some scenarios where forcing uniqueness makes the accessible experience worse. For example:

  • main contains a large table of search results.
  • The table has two identical sets of pagination controls; one above and one below.
  • Both sets of pagination controls are wrapped in <nav aria-label="search results".

Yes, you could ask for a design change so there is only one set of controls that does not scroll out of view. That possibility doesn't eliminate the existence of the scenario where there are two regions with identical content that do the same thing.

When I have seen this type of situation, every tweak I've toyed with to create uniqueness just makes the experience worse. So, I've advocated that it is better for the regions to have identical labels.

Perhaps this is a circumstance that is far more rare now than it was 8 or 10 years ago. When is the last time any of you have seen anything like it?

@jkva
Copy link

jkva commented Jun 14, 2018

@mcking65 the example you gave is a fair one. Given the documentation says should rather than must, each case is still covered. Optionally we could rewrite this to say:

If a specific landmark role is used more than once on a web page, ideally it should have a unique label.

Or provide an example for when duplicate landmark labels makes sense, such as the scenario you described.

mcking65 pushed a commit that referenced this issue Jun 15, 2018
Editorial clarification to landmark labeling guidance to explain when unique labels are needed and when duplicate labels may be appropriate.
@mcking65
Copy link
Contributor

@jkva, thank you for the feedback. @MichielBijl, thank you for raising the issue.

We now have a resolution with commit e8e10ea from pull request 687. Closing.

Landmark Regions Guidance and Examples Development Project automation moved this from Next Steps to Complete Jun 15, 2018
mcking65 pushed a commit that referenced this issue Jun 24, 2018
Editorial clarification to landmark labeling guidance to explain when unique labels are needed and when duplicate labels may be appropriate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Practice Page Related to a page within the practices section of the APG
Development

No branches or pull requests

3 participants