Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid Pattern: Missing guidance for use of aria-selected to support column selection #772

Closed
dusek opened this issue Jul 15, 2018 · 1 comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Pattern Page Related to a page documenting a Pattern

Comments

@dusek
Copy link
Contributor

dusek commented Jul 15, 2018

The 3.11 Grid pattern discusses in its WAI-ARIA section the following item:

  • If the grid supports selection, when a cell or row is selected, the selected element has aria-selected set true.

However the situation where a column is selected is not discussed, even though a keyboard shortcut of Control + Space is recommended for column selection action both for layout and data grids.

The reader reading the above-mentioned point is therefore left wondering whether e.g. WAI-ARIA does not support indicating column selection at the moment, or what workaround (e.g. set aria-selected=true on all cells in the selected column), if any, is or is not advised.

@mcking65 mcking65 added editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Pattern Page Related to a page documenting a Pattern labels Jul 20, 2018
@mcking65 mcking65 added this to Next Steps in Grids Pattern and Examples Development Project via automation Jul 20, 2018
@mcking65 mcking65 changed the title Grid: WAI-ARIA for selected column not discussed Grid Pattern: Missing guidance for use of aria-selected to support column selection Jul 20, 2018
mcking65 added a commit that referenced this issue Jul 20, 2018
Resolve issue #772 by adding the following to the states and properties section of the grid pattern in aria-practices.html:
`If the grid supports column selection and a column is selected, all cells in the column have <code>aria-selected</code> set to <code>true</code>.`
@mcking65
Copy link
Contributor

H@dusek, thank you for catching this. I have made a fix in commit a0c06a9. If you think the fix is not adequate, feel free to re-open this issue.

Grids Pattern and Examples Development Project automation moved this from Next Steps to Complete Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Pattern Page Related to a page documenting a Pattern
Development

No branches or pull requests

2 participants