Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example CSS files do not conform with APG coding guidelines #932

Closed
Chofoteddy opened this issue Oct 23, 2018 · 3 comments
Closed

Example CSS files do not conform with APG coding guidelines #932

Chofoteddy opened this issue Oct 23, 2018 · 3 comments
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Feedback Issue raised by or for collecting input from people outside APG task force Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Milestone
1.1 APG Release 4

Comments

@Chofoteddy
Copy link

Hi!

Reading the code of the CSS files, it is perceived that the same style is not followed. Later I found that in this same repository a guide of styles (same that recommend to use) is published.

Here, some examples that CSS files breaks the AGP (CSS Classes) and Code conformance:

I hope it's useful.
Greetings!
@annabbott
Copy link

https://stylelint.io/

@mcking65 mcking65 added the Feedback Issue raised by or for collecting input from people outside APG task force label Nov 5, 2018
@sh0ji
Copy link
Contributor

sh0ji commented Nov 22, 2018

I use stylelint for most of my frontend projects, and highly recommend it. It works almost identically to eslint, including the incredibly useful --fix flag for auto-fixing issues.

It should be relatively trivial to add it, but I suspect doing so may necessitate updating the CSS style guide. I'll open a PR for this.

@sh0ji sh0ji mentioned this issue Nov 22, 2018
Closed
mcking65 pushed a commit that referenced this issue Feb 4, 2019
@sh0ji @mcking65
Build Test Process: Implement style linting
a37d8a1 
For issue #932, implement stylelint for CSS files used for examples:
* add stylelint & hook to lint staged files.
* update linting scripts.
* add css linting to travis.
* update js linting script in ci.
* autofix css (npm run lint:css -- --fix).
* manually fix remaining stylelint errors.
* Add new aliases for npm run  of linting js, html, and css.
* update readme to document new linting conventions.
@mcking65 mcking65 added this to the 1.1 APG Release 4 milestone Feb 4, 2019
@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation labels Feb 4, 2019
@mcking65 mcking65 changed the title Break: AGP Styles in (CSS) demo files. Example CSS files do not conform with APG coding guidelines Feb 4, 2019
@mcking65
Copy link
Contributor

mcking65 commented Feb 4, 2019

Fixed with commit a37d8a1 thanks to @sh0ji!

@mcking65 mcking65 closed this as completed Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Feedback Issue raised by or for collecting input from people outside APG task force Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Milestone
1.1 APG Release 4
Development

No branches or pull requests
4 participants
@Chofoteddy @mcking65 @sh0ji @annabbott