Menubar #119
Closed
Menubar #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added two menubar examples, one is link and the other is action example.
initial commit for ARIA menubar example
|
Thanks, the copyright looks like something we can live with for now. The automated checks are failing: https://travis-ci.org/w3c/aria-practices/builds/164478496 I don't know if this is a result of the code Jesse added or something else, and whether it's important or not, but in some way we should get that to pass before accepting the pull request, as it will break automated generation of the editors' draft. Or accept the pull request and then go in to fix it, just knowing the editors' draft won't build until it's fixed. |
|
@a11ydoer will be correcting jscs errors and resubmitting so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed copyright to w3c and fixed file name errors in JS and HTML