Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sentence to Menu/Menubar pattern stating that the behavior is lik… #1232

Merged
merged 2 commits into from
Nov 11, 2019
Merged

Add sentence to Menu/Menubar pattern stating that the behavior is lik… #1232

merged 2 commits into from
Nov 11, 2019

Conversation

carmacleod
Copy link
Contributor

@carmacleod carmacleod commented Oct 28, 2019 •
edited by pr-preview bot
Loading

…e native OS menu behavior.

Adds the following sentence to the first paragraph of the Menu/Menubar pattern, as agreed upon by @mcking65 in #353 (comment) and @aardrian in #353 (comment):

Menu widgets behave like native operating system menus, such as the menus that pull down from the menubars commonly found at the top of many desktop application windows.

Note that this addresses one aspect of #353 but does not close it.

Preview | Diff

smhigley
smhigley approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@smhigley smhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to get this into 1.2 :)

mcking65
mcking65 approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carmacleod, thank you for the PR; looks good.

@mcking65 mcking65 merged commit a2b4df9 into master Nov 11, 2019
@mcking65 mcking65 deleted the issue353 branch November 11, 2019 09:27
michael-n-cooper pushed a commit that referenced this pull request Nov 11, 2019
Generated by TRAVIS-CI a2b4df9
049f6a1 
Menu pattern: Add statement that behavior is like native OS menus (pull #1232)

For issue #353,modify menu pattern to include:
>Menu widgets behave like native operating system menus,
>such as the menus that pull down from the menubars commonly found at the top of many desktop application windows.
@jasonwebb jasonwebb mentioned this pull request Jul 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smhigley smhigley smhigley approved these changes

@mcking65 mcking65 mcking65 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carmacleod @smhigley @mcking65