Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to Carousel Example with Buttons for Slide Control #1530

Merged
merged 3 commits into from Sep 30, 2020

Conversation

spectranaut
Copy link
Contributor

@spectranaut spectranaut commented Sep 24, 2020

I just notice the link to the first carousel example is broken in master:


Preview | Diff

@carmacleod
Copy link
Contributor

Thanks @spectranaut !
The link to carousel 1 seems to be broken on the second example page as well. Same fix needed there, too. :)

@spectranaut
Copy link
Contributor Author

done @carmacleod thx! :)

@nschonni
Copy link
Contributor

nschonni commented Sep 25, 2020

I think the same issue is fixed for a 3rd page with #1524 😄

@carmacleod
Copy link
Contributor

@nschonni

I think the same issue is fixed for the 3rd example page with #1524 😄

The fixes in this PR are in aria-practices.html and examples/carousel/carousel-2-tablist.html,
but the fixes in #1524 are in examples/index.html.

Does the script that generates examples/index.html (reference-tables.js, I believe?) run automatically?
If not, maybe it could now?

@nschonni
Copy link
Contributor

Sorry, I was just trying to say I think it's broken in a third place 😆

#1524 would make it run automatically, and also add a local commit hook as well, but I don't want to derail this PR thread

@carmacleod
Copy link
Contributor

Ohhh! Sorry! Now that I read your sentence more carefully, I totally get what you were saying. Oops! 😳

And thanks for the reply about running automatically - I should have read the comment in #1524 instead of just jumping to the Files changed tab to look for the broken link fix.

Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

This PR is good to go.
Thanks, @spectranaut !

@github-actions
Copy link
Contributor

Examples without any regression tests:

button/button_idl.html
dialog-modal/alertdialog.html


Examples missing some regression tests:

combobox/combobox-autocomplete-both.html:
    combobox-id
combobox/combobox-autocomplete-list.html:
    combobox-id
combobox/combobox-autocomplete-none.html:
    combobox-id
combobox/grid-combo.html:
    textbox-key-down-arrow
    textbox-key-up-arrow
dialog-modal/datepicker-dialog.html:
    textbox-aria-describedby
menu-button/menu-button-actions-active-descendant.html:
    menu-up-arrow
    menu-down-arrow
    menu-character
spinbutton/datepicker-spinbuttons.html:
    spinbutton-down-arrow
    spinbutton-up-arrow
    spinbutton-page-down
    spinbutton-page-up
    spinbutton-home
    spinbutton-end
toolbar/toolbar.html:
    toolbar-tab
    toolbar-right-arrow
    toolbar-left-arrow
    toolbar-home
    toolbar-end
    toolbar-toggle-esc
    toolbar-toggle-enter-or-space
    toolbar-radio-enter-or-space
    toolbar-radio-down-arrow
    toolbar-radio-up-arrow
    toolbar-button-enter-or-space
    toolbar-menubutton-enter-or-space-or-down-or-up
    toolbar-menu-enter-or-space
    toolbar-menu-down-arrow
    toolbar-menu-up-arrow
    toolbar-menu-escape
    toolbar-spinbutton-down-arrow
    toolbar-spinbutton-up-arrow
    toolbar-spinbutton-page-down
    toolbar-spinbutton-page-up
    toolbar-checkbox-space
    toolbar-link-enter-or-space
    toolbar-aria-controls
    toolbar-button-aria-pressed
    toolbar-button-aria-hidden
    toolbar-radiogroup-role
    toolbar-radiogroup-aria-label
    toolbar-radio-role
    toolbar-radio-aria-checked
    toolbar-radio-aria-hidden
    toolbar-button-aria-disabled
    toolbar-menubutton-aria-label
    toolbar-menubutton-aria-haspopup
    toolbar-menubutton-aria-controls
    toolbar-menubutton-aria-expanded
    toolbar-menu-role
    toolbar-menu-aria-label
    toolbar-menuitemradio-role
    toolbar-menuitemradio-aria-checked
    toolbar-menuitemradio-tabindex
    toolbar-spinbutton-role
    toolbar-spinbutton-aria-label
    toolbar-spinbutton-aria-valuenow
    toolbar-spinbutton-aria-valuetext
    toolbar-spinbutton-aria-valuemin
    toolbar-spinbutton-aria-valuemax


Examples documentation table rows without data-test-ids:

dialog-modal/alertdialog.html
    "Keyboard Support" table(s):
       Tab
       Shift + Tab
       Escape
       Command + S
       Control + S
    "Attributes" table(s):
       alertdialog
       aria-labelledby=IDREF
       aria-describedby=IDREF
       aria-modal=true
       alert

SUMMARTY:

  55 example pages found.
  2 example pages have no regression tests.
  8 example pages are missing approximately 61 out of approximately 775 tests.

ERROR - missing tests:

  Please write missing tests for this report to pass.

@mcking65 mcking65 added the bug Code defects; not for inaccurate prose label Sep 30, 2020
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Sep 30, 2020
@mcking65 mcking65 changed the title Fix link to carousel-prev-next example Fix links to Carousel Example with Buttons for Slide Control Sep 30, 2020
@mcking65 mcking65 merged commit 7c3b3cc into master Sep 30, 2020
@zcorpan zcorpan deleted the fix-carousel-link branch October 29, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code defects; not for inaccurate prose
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants