Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update menubar navigation example #1587

Closed
wants to merge 20 commits into from
Closed

Update menubar navigation example #1587

wants to merge 20 commits into from

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Oct 26, 2020

Update to menubar navigation exmaple is ready for review:

Preview Link

Changes:

  • Added landmark regions to mimic a website look and feel
  • When links selected the content area is updated and the focus moves to the H1 element, previous version went to a dummy link
  • Updated code to use coding practices

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2020

Regression test coverage:

Examples without any regression tests:

  • dialog-modal/alertdialog.html

Examples missing some regression tests:

  • dialog-modal/datepicker-dialog.html:
    • textbox-aria-describedby
  • menu-button/menu-button-actions-active-descendant.html:
    • menu-up-arrow
    • menu-down-arrow
    • menu-character
  • menubar/menubar-navigation.html:
    • menubar-space-or-enter
    • menubar-right-arrow
    • menubar-left-arrow
    • menubar-down-arrow
    • menubar-up-arrow
    • menubar-home
    • menubar-end
    • menubar-character
    • submenu-space-or-enter
    • submenu-escape
    • submenu-right-arrow
    • submenu-left-arrow
    • submenu-down-arrow
    • submenu-up-arrow
    • submenu-home
    • submenu-end
    • submenu-character
    • banner-role
    • navigation-role
    • navigation-aria-label
    • region-role
    • region-aria-label
    • contentinfo-role
    • menuitem-role
    • menuitem-aria-current
    • menuitem-aria-haspopup
    • menuitem-aria-expanded
    • menuitem-aria-owns
    • none-role
    • menu-role
    • menu-aria-label
    • sub-menuitem-role
    • sub-menuitem-tabindex
    • sub-menuitem-aria-haspopup
    • sub-menuitem-aria-expanded
    • sub-none-role
  • toolbar/toolbar.html:
    • toolbar-tab
    • toolbar-right-arrow
    • toolbar-left-arrow
    • toolbar-home
    • toolbar-end
    • toolbar-toggle-esc
    • toolbar-toggle-enter-or-space
    • toolbar-radio-enter-or-space
    • toolbar-radio-down-arrow
    • toolbar-radio-up-arrow
    • toolbar-button-enter-or-space
    • toolbar-menubutton-enter-or-space-or-down-or-up
    • toolbar-menu-enter-or-space
    • toolbar-menu-down-arrow
    • toolbar-menu-up-arrow
    • toolbar-menu-escape
    • toolbar-spinbutton-down-arrow
    • toolbar-spinbutton-up-arrow
    • toolbar-spinbutton-page-down
    • toolbar-spinbutton-page-up
    • toolbar-checkbox-space
    • toolbar-link-enter-or-space
    • toolbar-spinbutton-role

Example pages with Keyboard or Attribute table rows that do not have data-test-ids:

  • dialog-modal/alertdialog.html
    • "Keyboard Support" table(s):
      • Tab
      • Shift + Tab
      • Escape
      • Command + S
      • Control + S
    • "Attributes" table(s):
      • alertdialog
      • aria-labelledby=IDREF
      • aria-describedby=IDREF
      • aria-modal=true
      • alert

SUMMARY:

52 example pages found.
1 example pages have no regression tests.
4 example pages are missing approximately 63 out of approximately 788 tests.

ERROR - missing tests:

Please write missing tests for this report to pass.

@jongund
Copy link
Contributor Author

jongund commented Nov 11, 2020

@mcking65
@spectranaut
I am getting eslinting errors on many files (e.g. "error Use the global form of 'use strict' strict") that are not part of this pull request, what should I do?
I have merged from master, but still getting the errors.

@nschonni
Copy link
Contributor

@jongund was able to reproduce your issues locally, but I was able to resolve the issue by rebasing. You could try this locally to see if if helps, but might put you in a "bad" state if you're not familiar with git:

  1. git pull --rebase upstream master. upstream might not be the right remove for you since this branch is in the same repo
  2. Resolve the git conflicts through the rebase
  3. git rebase -i HEAD~16 and squashed down all the commits using "fixup" choice for all but the first commit
  4. I copied the end test/tests/menubar_menubar-navigation.js from here since my rebase left it in a bad state

You'd need to force push back the branch at the end.

I can submit my end branch if you want, and just let push your updates to it if you want

@jongund jongund closed this Nov 11, 2020
@jongund
Copy link
Contributor Author

jongund commented Nov 11, 2020

messed up synchronization of files with master, so going to start over, by deleting this branch and creating a new branch for menubar navigation updates.

@jongund jongund deleted the update-menubar-nav branch November 11, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants