Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Switch Example using HTML button Element #1893

Merged
merged 58 commits into from
Oct 29, 2021
Merged

Add Switch Example using HTML button Element #1893

merged 58 commits into from
Oct 29, 2021

Conversation

jongund
Copy link
Contributor

@jongund jongund commented May 5, 2021 •
edited by pr-preview bot
Loading

@jongund jongund changed the title Initial switch example using button and SVG images for graphical state Switch example using button and SVG images for graphical state May 5, 2021
@jongund jongund changed the title Switch example using button and SVG images for graphical state Switch Role: Example using button and SVG May 6, 2021
@jongund jongund changed the title Switch Role: Example using button and SVG Switch Role: Example using button and inline SVG May 6, 2021
@a11ydoer a11ydoer requested review from spectranaut and mcking65 and removed request for mcking65 May 11, 2021 18:35
@jongund
Copy link
Contributor Author

jongund commented May 27, 2021

@mcking65
Made update to move on/off labels from CSS to content, may need aria-hidden.

@jongund jongund requested review from smhigley, charmarkk, a11ydoer and jesdaigle and removed request for spectranaut July 13, 2021 20:32
jesdaigle
jesdaigle reviewed Aug 30, 2021
View reviewed changes
examples/switch/switch-button.html
</td>
</tr>
<tr data-test-id="switch-aria-checked">
<td></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesdaigle what are you referring to when you ask about "this"? Asking about the presence of the first cell in the row? The first ceel is for role, which is blank in this row b/c this is a row describing attributes of the row for the switch role.

@mcking65 mcking65 added the Example Page Related to a page containing an example implementation of a pattern label Oct 3, 2021
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Oct 3, 2021
@mcking65 mcking65 removed a link to an issue Oct 3, 2021
Checks failing on push #2040
Closed
@mcking65 mcking65 removed the request for review from smhigley October 3, 2021 20:18
mcking65
mcking65 approved these changes Oct 3, 2021
View reviewed changes
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial review is complete.

I will add a link from the main doc and update the similar examples list after #1895 is merged and before merging this.

@jongund
Copy link
Contributor Author

jongund commented Oct 5, 2021

@mcking65
I made some updated to the accessibility feature documentation, so should be good to go now.

howard-e
howard-e reviewed Oct 26, 2021
View reviewed changes
test/tests/switch_switch-button.js Outdated Show resolved Hide resolved
test/tests/switch_switch-button.js Outdated Show resolved Hide resolved
@mcking65 mcking65 changed the title Switch Role: Example using button and inline SVG Add Switch Example using HTML button Element Oct 29, 2021
@mcking65 mcking65 merged commit 533328e into main Oct 29, 2021
@mcking65 mcking65 deleted the switch-button branch October 29, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcking65 mcking65 mcking65 approved these changes

@howard-e howard-e howard-e approved these changes

@a11ydoer a11ydoer a11ydoer approved these changes

@charmarkk charmarkk Awaiting requested review from charmarkk

@jesdaigle jesdaigle Awaiting requested review from jesdaigle

Assignees
No one assigned
Labels
Example Page Related to a page containing an example implementation of a pattern
Projects
Switch pattern and example developmen...
In progress
Milestone
1.2 Release 1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jongund @a11ydoer @howard-e @mcking65 @jesdaigle