Providing Accessible Names Practice: Change heading levels to make page TOC more informative #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy Preview - https://deploy-preview-94--wai-aria-practices2.netlify.app/ |
|
Here is the exact Deploy Preview URL for Providing Accessible Names and Descriptions It looks good to me with 10 items in the "Page Contents" section. Special thanks for figuring out the build problem, @richnoah and your team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current side bar containing the page TOC for the naming and describing practice page includes only the following:
Items 4 and 5 are large sections. It is difficult for users to know what is on the page with so many subsections tucked away under them.
This PR proposes removing the headings associated with items 4 and 5 to bump up their subsections and expose them in the page TOC.
Preview new version
View the new version with 10 items in the page contentes side bar
💥 Error: 504 Gateway Timeout 💥
PR Preview failed to build. (Last tried on May 17, 2022, 7:25 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.