Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Page: Expand ARIA acronym, add APG acronym to h1, fix link labels, fix mailing list link visibility #2379

Merged
merged 5 commits into from
Jun 22, 2022

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Jun 13, 2022

Fixes #2328
Fixes #2378
Tries fixing #2327

Preview Link


WAI Preview Link

@mcking65
Copy link
Contributor Author

@richnoah @alflennik

In 6d60ae8, I moved the link outside the paragraph, and now the link does not render.

@mcking65 mcking65 changed the title Home Page: Expand ARIA, fix link labels Home Page: Expand ARIA acronym, add APG acronym to h1, fix link labels, fix mailing list link visibility Jun 13, 2022
@alflennik
Copy link
Contributor

Hi @mcking65! Only p tags are supported inside that section. Could you try wrapping the link in a p tag and see if that resolves it?

@mcking65
Copy link
Contributor Author

@alflennik wrote:

Hi @mcking65! Only p tags are supported inside that section. Could you try wrapping the link in a p tag and see if that resolves it?

Thank you Alex! That worked. I hope it looks OK visually.

@mcking65
Copy link
Contributor Author

@jongund @charmarkk

I finished the edits we discussed in the meeting. This is ready for review now.

I'd like to know if you think this fully addresses the feedback in #2327.

@richnoah
Copy link
Contributor

@mcking65 from a visual inspection all the requirements have been met.

@charmarkk
Copy link
Contributor

@mcking65 +1 to @richnoah - LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants