Breadcrumb #266
Breadcrumb #266
Conversation
modified examples/breadcrumb/index.html: * Changed crumb links to better represent the position of this page in APG architecture. The first link should point to main doc, not outside APG. The second link is for the design pattern section, the third link for the breadcrumb pattern, and the final link to the breadcrumb example page. * Editorial revisions to intro and accessibility features.
modified examples/breadcrumb/index.html: 1. Remove links from states and properties in Breadcrumb example. We are not maintaining links to the aria spec or html spec from example pages; they are not respec documents. 2. Editorial revision to description in aria-current row.
modified examples/breadcrumb/index.html: In the states and properties table, added a row for the nav element and aria-label property.
|
@MichielBijl, I added 3 more commits. If you and @jnurthen are OK with the changes, I see no need to keep all the individual commits in the history ... we should squash it. |
|
I’m fine with all but the removal of the links to properties and elements. I for one find it very useful to have cross references to other specs and the like. This is also a step towards the more “developer reference”-ness of the APG. It makes it a lot easier to look up elements and attributes that you might not be familiar with. We can discuss where it should link, but I figured TR would be the correct location. Any arguments to take it out? |
|
We do not have the role/state/property links in the example pages because we do not have a way of ensuring they point to the correct place. The example pages are not respec documents. During the editors' call, I had a discussion with Michael about isolating just the reference generation capabilities of respec for certain pages so we could do things like that. We do not want to turn the example pages into respec docs. In general, I don't think we should link to other specs unless there is something unusual that justifies it. For example, I think it is better not to have links to the spec for common html elements. They could be more of a distraction than a help to readers. Would you be interested in taking on issue #270? |
Fix issues in #187. Please squash the commits in this PR.