Treegrid Pattern keyboard section: Correct text for Control + Home/End #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcking65
requested changes
Aug 29, 2023
There was a problem hiding this comment.
Thank you @andrewnicols! I think this is more clear. However, I think there is a typo in ctrl+end. suggestion provided.
The text in the treegrid pattern differed to the text in the treegrid example. The content of the treegrid pattern was nonsensical as a column only contains one cell so moving focus to the first cell in a column is meaningless. The behaviour and text of the example are consistent and make logical sense. Inaccurate text: If focus is on a cell, moves focus to the first cell in the column. If focus is on a cell, moves focus to the last cell in the column. Corrected text: If focus is on a cell, moves focus to the cell in the first row in the same column as the cell that had focus. If focus is on a cell, moves focus to the cell in the last row in the same column as the cell that had focus.
andrewnicols
force-pushed
the
treegridControlCell
branch
from
1579506
to
0f9f08a
Compare
mcking65
added
editorial
mcking65
added this to Next Steps
in Tree and Treegrid Pattern and Examples Development Project
via automation
mcking65
changed the title
mcking65
added
Pattern Page
mcking65
moved this from Next Steps
to In Progress
in Tree and Treegrid Pattern and Examples Development Project
Tree and Treegrid Pattern and Examples Development Project
automation
moved this from In Progress
to Complete
Sep 19, 2023
|
Thank you @andrewnicols for the fix!! It will go live in the next publication, which is typically at the end of the month. |
mcking65
modified the milestones:
ARIA 1.3 Additions,
2023-10-02 Publication Pull Requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text in the treegrid pattern differed to the text in the treegrid example. The content of the treegrid pattern was nonsensical as a column only contains one cell so moving focus to the first cell in a column is meaningless.
The behaviour and text of the example are consistent and make logical sense.
Inaccurate text:
Control + Home: If focus is on a cell, moves focus to the first cell in the column.
Control + End: If focus is on a cell, moves focus to the last cell in the column.
Corrected text:
Control + Home: If focus is on a cell, moves focus to the cell in the first row in the same column as the cell that had focus.
Control + End: If focus is on a cell, moves focus to the cell in the last row in the same column as the cell that had focus.
WAI Preview Link (Last built on Wed, 30 Aug 2023 08:03:27 GMT).