-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disclosure: Updated alt text of image, text content of figure caption #315
Conversation
Merge branch 'master' into disclosure
Merge remote-tracking branch 'w3c/master' into disclosure
Looking at I fixed this with commit 0ea92b4. The result can be seen here: This reveals a pretty nasty JAWS bug: only a portion of the figcaption is rendered. The disclosure is not available to JAWS users. So, this is a pretty useful test case. It works reasonably well with NVDA in FF, Chrome, and IE11. @jongund, are you OK with these changes? @jnurthen, please have a look. |
In examples/disclosure/disclosure-img-long-description.html: 1. Structured text in figcaption element with `<p>` elements. 2. Moved disclosure button and disclosure content inside of the `<figcaption>` element. Fixed JSCS error in examples/disclosure/js/disclosureButton.js.
I think the center align on the caption makes the text really hard to read. Any objection to left aligning it? |
Looking at the spec for figcaption it states that it can include flow elements or text. Button is not a flow element so I'm not sure this example is valid. Of course we could put the button inside a div and that would be valid (I think) but I think we need a change. |
@jnurthen, the spec for button |
You are right. Serves me right for looking at an inaccurate document.... http://w3c.github.io/html-reference/common-models.html#common.elem.flow Happy for you to squash and merge. |
Matt I have made the changes and it looks like this branch is clean for a merge |
@jongund, yes, this pull does indeed make the needed changes and tests clean. Thanks! I am merging. |
I also fixed the problem with the figcaption tag, it was in the document as caption