Disclosure: Updated alt text of image, text content of figure caption

[jongund]

I also fixed the problem with the figcaption tag, it was in the document as caption

[mcking65]

Looking at
spec for figcaption,
the figcaption has to be the first or last element inside the figure.

I fixed this with commit 0ea92b4.

The result can be seen here:
https://rawgit.com/jongund/aria-practices/disclosure/examples/disclosure/disclosure-img-long-description.html

This reveals a pretty nasty JAWS bug: only a portion of the figcaption is rendered. The disclosure is not available to JAWS users. So, this is a pretty useful test case.

It works reasonably well with NVDA in FF, Chrome, and IE11.

@jongund, are you OK with these changes?

@jnurthen, please have a look.

[jnurthen]

I think the center align on the caption makes the text really hard to read. Any objection to left aligning it?

[jnurthen]

Looking at the spec for figcaption it states that it can include flow elements or text. Button is not a flow element so I'm not sure this example is valid. Of course we could put the button inside a div and that would be valid (I think) but I think we need a change.

[mcking65]

@jnurthen, the spec for button
says it is in the flow content category and the
spec for flow content
lists button. So, I think we are OK with a button inside of a figcaption.

[jnurthen]

You are right. Serves me right for looking at an inaccurate document.... http://w3c.github.io/html-reference/common-models.html#common.elem.flow

Happy for you to squash and merge.

[jongund]

Matt I have made the changes and it looks like this branch is clean for a merge

[mcking65]

@jongund, yes, this pull does indeed make the needed changes and tests clean. Thanks! I am merging.