Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variables #632

Merged
merged 5 commits into from Apr 28, 2018
Merged

Remove unused variables #632

merged 5 commits into from Apr 28, 2018

Conversation

fALKENdk
Copy link
Contributor

@fALKENdk fALKENdk commented Apr 6, 2018

Removed unused variables.

@fALKENdk
Update MenuItemAction.js
fdebbe1 
Removed unused variables.
@fALKENdk
Update MenuItemLinks.js
fbe6ec9 
Removed unused variables
@fALKENdk
Update Menubutton.js
66f42d8 
Removed unused variables
@fALKENdk
Update Menubutton2.js
effe8ef 
Removed unused variables
@fALKENdk
Update PopupMenuActionActivedescendant.js
cdada84 
Removed unused variables
@mcking65 mcking65 requested a review from jongund April 15, 2018 19:13
@mcking65 mcking65 self-assigned this Apr 15, 2018
@mcking65 mcking65 added this to the 1.1 APG Release 2 milestone Apr 15, 2018
@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation labels Apr 15, 2018
@ZoeBijl
Copy link
Contributor

ZoeBijl commented Apr 16, 2018

This checks out, thanks @fALKENdk.

@jongund can you confirm before we merge this?

@ZoeBijl ZoeBijl self-requested a review April 16, 2018 09:56
jongund
jongund approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@jongund jongund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for cleaning up the code.

@ZoeBijl ZoeBijl merged commit 8cb2b4c into w3c:master Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jongund jongund jongund approved these changes

@ZoeBijl ZoeBijl ZoeBijl approved these changes

Assignees

@mcking65 mcking65

Labels
Example Page Related to a page containing an example implementation of a pattern Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
Command, Toggle, Menu, and Disclosure...
  
Complete
Milestone
1.1 APG Release 2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fALKENdk @ZoeBijl @jongund @mcking65