Navigation Menu Button Example: fix unreachable code and shift-tab not closing menu

[jongund]

Issue #396: Fixes the unreachable code problem
Issue #588: Fixes shift-tab not closing the menu
Updated CSS focus styling

Preview link

Navigation menu button example in Jon's fork

[mcking65]

@jongund, the fix for issue 588 looks good. I think 396 as well; @sh0ji, could you look at that?

I'm curious about the css changes. They were not part of either of these issues. Please describe them.

[sh0ji]

The 396 fix looks good to me.

The style changes look purely cosmetic to me, but there are at least two issues:

• The border of the role=menu is not connecting at the top-left and top-right corners the way it should.
• The role=menuitem boxes resize on hover a tiny bit, causing the text to shift.

I'd recommend doing the style changes in a different PR if that's possible.

[mcking65]

@sh0ji, thank you! @jongund, I too would prefer a separate PR for the styling. In general, I prefer one PR per issue ... it doesn't have to always be that way for small issues, but it is a good rule of thumb.

Please back out the CSS file changes and I will merge.

Then, if you want to address Evan's feedback in another PR, that would be good.

[jongund]

I removed the CSS changes from the original pull request