Roles with required states missing from characteristics table for those states

[joanmarie]

In http://www.w3.org/TR/wai-aria-1.1/#aria-selected, option is missing from "used in roles"; "treeitem" is missing from "inherits into roles".

In http://www.w3.org/TR/wai-aria-1.1/#aria-checked, checkbox and radio are missing from "used in roles"; menuitemcheckbox and menuitemradio are missing from "inherits into roles".

There may be others. I have a potential fix.

[joanmarie]

The branch above solves the problem for me. Disclaimer: What I know about jquery, I pretty much learned looking into this bug while multitasking. ;)

In addition, I see that something is pulling the "checked" state in twice for role radio, which I'm betting is a spec duplication. I'll check next. In the meantime, if someone who actually is familiar with jquery and our scripts could take a look, it would be teh awesome. Thanks!

[joanmarie]

Aha, radio currently has "checked" as a "required property" (which makes sense). But the superclass of radio is checkbox which, of course, has "checked" as a "required property" as well. I guess the aria.js method needs to filter out duplicates.

[halindrome]

It was supposed to filter out duplicates as a matter of course. Hrm. I will walk through it, but it might not be today.

[joanmarie]

Well, maybe it does but my change breaks that. ;) I'll give it a bit more time today. If not, I'll defer to you to fix it.

[joanmarie]

Found it! 3af0455 Now that branch includes the roles that were missing, but only does so once.

The disclaimer above still applies. So @halindrome when you get a chance, could you please review? And if there's a better way to do it -- and it's faster for you to just do it, please do. Now that I see this bug, it's pretty bad....

Thanks!

[halindrome]

I will look at it tomorrow. I actually noticed it a few weeks back but
thought it was isolated to one role. My bad.
On Apr 24, 2015 4:14 PM, "Joanmarie" notifications@github.com wrote:

Found it! 3af0455 3af0455 Now that
branch includes the roles that were missing, but only does so once.

The disclaimer above still applies. So @halindrome
https://github.com/halindrome when you get a chance, could you please
review? And if there's a better way to do it -- and it's faster for you to
just do it, please do. Now that I see this bug, it's pretty bad....

Thanks!

—
Reply to this email directly or view it on GitHub
#48 (comment).

[halindrome]

Your changes look good to me. I think I will need to push the into ariaChild.js too. Do you want to make the pull request, or do you want me to do it?

[michael-n-cooper]

Appears to be fixed, closing.