Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify if aria-selected & aria-checked are required on roles 'treeitem' & ('menuitemcheckbox', 'menuitemradio') respectively #798

Open
iamrafan opened this issue Aug 13, 2018 · 3 comments
Assignees
Labels
clarification clarifying or correcting language that is either confusing, misleading or under-specified
Projects
Milestone

Comments

@iamrafan
Copy link

iamrafan commented Aug 13, 2018

The ARIA 1.1 treeitem spec mentions that aria-selected is a required attribute but the aria-selected spec mentions that it inherits into role treeitem and need not be explicitly used on this role.

Please clarify if aria-selected is a required or a supported attribute on role treeitem?

aria-checked on roles menuitemcheckbox and menuitemradio also have the same issue

@iamrafan iamrafan changed the title Clarify if aria-selected is required on role treeitem Clarify if aria-selected & aria-checked are required on roles 'treeitem' & ('menuitemcheckbox', 'menuitemradio') respectively Aug 14, 2018
@mcking65 mcking65 added this to the ARIA 1.2 milestone Aug 15, 2018
@mcking65 mcking65 self-assigned this Aug 15, 2018
@mcking65
Copy link
Contributor

treeitem is inherriting from option, and option has aria-selected as required, which does not make sense. See #700.

We also have a presentation problem in the spec. If the superclass role of a role requires a property, the subclass role does not have a row in the table for required properties. Instead, the string "(required)" is placed in the list of inherrited states and properties. This makes it very difficult to notice that an inheritted property is required. I think this inconsistency is problematic. It occurs in 3 places:

  1. aria-selected on treeitem. This will go away if we do not require aria-selected on option as suggested in Should aria-selected be listed as required for option role?  #700.
  2. aria-checked on menuitemcheckbox
  3. aria-checked on menuitemradio

I do not think that it is absolutely necessary that aria-checked be a required property on radio, menuitemradio, checkbox, or menuitem checkbox. In all cases, the default value is false for aria-checked. On the other hand, if a validator calls out a missing aria-checked declaration, it is potentially helpful.

I am sure there are "invalid" implementations that rely on the default value to work. So, we would not want to keep it required and remove the default value.

@scottaohara
Copy link
Member

also related #1052

@mcking65
Copy link
Contributor

Note to self ... part of the solution here is changing tree item so it does not inherit from option.

@spectranaut spectranaut added this to Matt King in ARIA 1.3 Jun 7, 2022
@spectranaut spectranaut added the clarification clarifying or correcting language that is either confusing, misleading or under-specified label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification clarifying or correcting language that is either confusing, misleading or under-specified
Projects
ARIA 1.3
Matt King
Development

No branches or pull requests

5 participants