-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guidance section about Communicating Widget States (replaced by #2071) #1277
Conversation
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<carmacleod> TOPIC: States<zcorpan> GitHub: https://github.com//pull/1277 <zcorpan> https://github.com/w3c/aria-practices/blob/c356a98dc1f4c4e851ec93d7572c46333de12184/widget-states.md <carmacleod> mck: if there are any states that are not touched on here, please comment in pr |
I have addressed review comments from @mcking65, except I haven't moved the discussion of HTML equivalents to the end. Please review the current version. If it would be clearer to discuss HTML equivalents in its own section, we can change that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zcorpan !
If possible, can you look into maybe using a different tool to convert from markdown to markup? The tool you were using seems buggy. It sometimes misses a space after </code>
or </a>
in a sentence.
Sorry if there was a lot of email spam... by the time I realized how many missing spaces there were, I had already flagged most of them... and then I thought I should just commit them to get them out of the way...
There should still be 8 or so suggestions left that weren't just "missing space" or "extra word". You might have to click "Load more..." to see them.
Reminder that there are still 2 "TODO" items.
We can talk about these sub topics at APG meeting on 4/14/2020
|
@mcking65 @joanmarie @jnurthen I complied ARIA issues which mentioned widget states so that we can cosider those in APG spec. Any comments and feedback are welcomed. |
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<carmacleod> TOPIC: Widget States<Jemma> ARIA 1008 <Jemma> ARIA 1777 <Jemma> ARIA 1052 <Jemma> ARIA 700 <Jemma> ARIA 1130:aria-disabled <Jemma> ARIA 1026:aria-expanded: <Jemma> ARIA 798:aria-selected on tree item <Jemma> ARIA 542 <Jemma> ARIA 684 <Jemma> https://github.com//pull/1277 <siri> ./me unable to join via zoom <carmacleod> github: https://github.com//pull/1277 <carmacleod> Jemma: aria-checked is in pretty good shape <carmacleod> Jemma: Which one should we focus on next, so that we can get through these? <Jemma> https://pr-preview.s3.amazonaws.com//pull/1277.html#communicating_widget_states_aria-selected <carmacleod> mck: Need to help people understand the difference between selected, checked, and pressed. <Jemma> https://github.com/w3c/aria/issues/798 <carmacleod> mck: Not sure if this is organized in a way that makes that easy to explain <Jemma> Clarify if aria-selected & aria-checked are required on roles 'treeitem' & ('menuitemcheckbox', 'menuitemradio') respectively #798 <carmacleod> sarah_higley: Agree <carmacleod> mck: Is that in 7.1.2? <carmacleod> sarah_higley: Yes <carmacleod> mck: Is it specifically the paragraph where it's talking about orthogonal states? Is that the part that's unclear? <carmacleod> sarah_higley: Yes. I don't know what the use case would be. I think it's a bad idea to use both. <Jemma> https://github.com/w3c/aria/issues/1052 <Jemma> This issue is more close to the current dicussion. <carmacleod> mck: If you have checked representing "include this in some action" <carmacleod> sarah_higley: we never have checked and selected - instead have extra actions <siri> ./me trying meeting number but no use <jamesn> nods enthusiastically to sarah_higley <jamesn> we need to come up with an additional actions pattern <BGaraventa> +q <carmacleod> sarah_higley: mixed value for checkbox is not supported on treeitems <carmacleod> Jon_Gunderson: there's a discrepancy, because it also says it's not supported on other roles <carmacleod> sarah_higley: checked is not as well supported as selected <Jon_Gunderson> https://w3c.github.io/aria/#aria-checked <carmacleod> sarah_higley: selected is quite well supported <carmacleod> mck: ARIA should say that you should only use one or the other, but not both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcking65 I added a couple review comments based on what was talked about in the meeting
</ul> | ||
|
||
<p> | ||
However, the <code>mixed</code> value is only supported for the <code>checkbox</code> and <code>menuitemcheckbox</code> roles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mixed
is currently supported on option
and treeitem
as well (and only prohibited on radio, menuitemradio, and switch), per the ARIA spec
aria-practices.html
Outdated
<p> | ||
In rare cases, a widget could support both selection and checkedness to represent orthogonal states, | ||
although that could be complex and might be confusing for users. | ||
For example, a <code>tree</code> widget to represent a changeable sequence of steps, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the discussion in the APG meeting today, we decided on removing this example, and adding guidance to indicate that a valid use of aria-checked
over aria-selected
is when you need to support a mixed selection state, but that both attributes should not be used at the same time.
Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
There was a merge commit in this branch, and I couldn't for the life of me get rid of it (to instead squash and rebase) without having to deal with something like 100 merge conflicts. So I created a new branch and opened a new PR: #2071 |
Replaces #1057
Preview | Diff