Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined behavior for Element and FrozenArray<Element> reflecting IDL attributes #978

Closed
zcorpan opened this issue May 3, 2019 · 7 comments
Closed

Undefined behavior for Element and FrozenArray<Element> reflecting IDL attributes #978

zcorpan opened this issue May 3, 2019 · 7 comments
Assignees
@alice @cyns
Projects
IDL
Milestone
2023

Comments

@zcorpan
Copy link
Member

zcorpan commented May 3, 2019

HTML does not define any reflection behavior for these types. The getters and setters need to be explicitly defined.

https://w3c.github.io/aria/#AriaAttributes

It's also unclear to me what the setters for the *Element or *Elements IDL attributes should do. What if an ID-less element is assigned? Is the association still made? How? What is the content attribute set to? Or are these supposed to be readonly?
@jnurthen
Copy link
Member

@alice

@jnurthen
Copy link
Member

@zcorpan I believe this is in whatwg/html#3917 - HTML wanted a usage before merging.

@alice
Copy link

alice commented May 16, 2019

Yep, what @jnurthen said. Will be working on an implementation in Blink shortly as well.

@zcorpan
Copy link
Member Author

zcorpan commented May 16, 2019

OK, nice! That answers my questions. It also makes the association well-defined, such that it would be good to define the ARIA mapping in terms of [[attrAssociatedElement]] and [[attrAssociatedElements]] directly.

@joanmarie joanmarie added this to the ARIA 1.2 milestone May 16, 2019
@zcorpan
Copy link
Member Author

zcorpan commented Jun 27, 2019

cc @spectranaut

@jnurthen jnurthen added this to To do in IDL Nov 13, 2019
@jnurthen jnurthen modified the milestones: ARIA 1.2, ARIA 1.3 Apr 30, 2020
@cookiecrook
Copy link
Contributor

Moving to ARIA 1.3 because we're removing the element reflection attributes as part of #834.

@cyns cyns self-assigned this Oct 25, 2021
@spectranaut spectranaut added this to Cynthia Shelly in ARIA 1.3 Jun 7, 2022
mrego added a commit to mrego/aria that referenced this issue Jun 10, 2022
@mrego
Resolves w3c#978, add back ARIA element reflection IDL
e0490c3 
Now that HTML spec defines reflection for Element and FrozenArray<Element> attributes
(see whatwg/html#7934), we can add back these attributes to ARIA IDL.

This is simply a revert of w3c#1260.
@mrego
Copy link
Member

mrego commented Jun 10, 2022

This is now defined in the HTML spec: https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#reflecting-content-attributes-in-idl-attributes

I've just made a PR to add things back to ARIA spec: #1755

@pkra pkra closed this as completed in 060b878 Jul 8, 2022
IDL automation moved this from To do to Done Jul 8, 2022
github-actions bot added a commit that referenced this issue Jul 8, 2022
@mrego @github-actions
Resolves #978, add back ARIA element reflection IDL (#1755)
16f8875 
SHA: 060b878
Reason: push, by @pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jnurthen added a commit that referenced this issue Aug 31, 2022
@jnurthen
Resolves #978, add back ARIA element reflection IDL (#1755)
2adf814 
Now that HTML spec defines reflection for Element and FrozenArray<Element> attributes
(see whatwg/html#7934), we can add back these attributes to ARIA IDL.

This is simply a revert of #1260.
@spectranaut spectranaut removed this from Cynthia Shelly in ARIA 1.3 Sep 16, 2022
jnurthen pushed a commit that referenced this issue Oct 10, 2023
@mrego @jnurthen
Resolves #978, add back ARIA element reflection IDL (#1755)
3e192b4 
Now that HTML spec defines reflection for Element and FrozenArray<Element> attributes
(see whatwg/html#7934), we can add back these attributes to ARIA IDL.

This is simply a revert of #1260.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alice alice

@cyns cyns

Labels
None yet
Projects
IDL
  
Done
Milestone
2023
Development

No branches or pull requests
7 participants
@mrego @cookiecrook @alice @zcorpan @jnurthen @joanmarie @cyns