remove allowance of group in lists #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removes allowance of `group` within `list` * changes notes and examples that referred to `list` and `group`s containing `listitem`s to instead reference `listbox` and `group`s containing `option`s, as that is a similar, allowed pattern. changes affect content of: * Required Owned Elements * group role * list role * listitem role
mcking65
requested changes
Oct 9, 2019
mcking65
approved these changes
Oct 10, 2019
jnurthen
pushed a commit
that referenced
this pull request
Oct 12, 2019
carmacleod
pushed a commit
that referenced
this pull request
May 7, 2020
* removes allowance of `group` within `list` * changes notes and examples that referred to `list` and `group`s containing `listitem`s to instead reference `listbox` and `group`s containing `option`s, as that is a similar, allowed pattern. changes affect content of: * Required Owned Elements * group role * list role * listitem role * remove reference to groups in directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1011
groupwithinlist.listandgroups containinglistitems to instead referencelistboxandgroups containingoptions, as that is a similar, allowed pattern.changes affect content of:
grouprolelistrolelistitemroleI created a test page to quickly log current browser w/screen reader behavior. At best, a named group would be announced by some screen reader/browser combos. On the other end, groups within lists made VO with Safari ignore the lists semantics all together.
Preview | Diff