Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate role=directory #1080

Merged
merged 2 commits into from
Oct 12, 2019
Merged

deprecate role=directory #1080

merged 2 commits into from
Oct 12, 2019

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Oct 3, 2019 •
edited by pr-preview bot

closes #1076

Preview | Diff

mcking65
mcking65 requested changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enthusiastically endorse!!!

There is a missing comma that needs to be fixed. And, I have suggested what I think is slightly more clear wording for the note.

index.html Outdated Show resolved Hide resolved
@scottaohara @mcking65
Update index.html
fe4e66e 
i like it, thanks

Co-Authored-By: Matt King <a11yThinker@Gmail.com>
mcking65
mcking65 approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now

@jnurthen jnurthen merged commit fcd25ba into master Oct 12, 2019
jnurthen pushed a commit that referenced this pull request Oct 12, 2019
@scottaohara @jnurthen
deprecate role=directory (#1080)
0c7de4b
carmacleod pushed a commit that referenced this pull request May 7, 2020
@scottaohara @carmacleod
deprecate role=directory (#1080)
062b30a
@jnurthen jnurthen deleted the so_1076_deprecate_directory branch July 23, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcking65 mcking65 mcking65 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider deprecating role=directory
3 participants
@scottaohara @mcking65 @jnurthen