Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox: Revise UA, AT, and checker guidance per agreed text in issue 1178 #1223

Merged
merged 3 commits into from
Apr 28, 2020

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Mar 26, 2020

Fixes #1178


Preview | Diff

Copy link
Contributor

@jongund jongund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it covers conformance checking and assistive technology implementation issues.

Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that can be addressed in the APG rather than in the spec? This new edit feels like an informative note, but it's written in formal RFC-2119 prose. For example, the advice to user agents to continue to make the legacy pattern work is not something that should be a formal requirement of the specification.

The conformance checkers statement seems out of place, too. The term SHOULD (not MAY) requires conformance checkers to recognize a complex-and-deprecated usage pattern documented elsewhere, rather than a concrete pattern (warn if specific markup is thus).

Even the author requirement is out of place, IMO: "Authors SHOULD convert implementations of the ARIA 1.1 pattern to the ARIA 1.2 pattern."

It should be concrete or not there at all. I'd rather the paragraph be deleted entirely from the spec.

@cookiecrook
Copy link
Contributor

I'd rather this paragraph be deleted entirely from the spec.

Alternately, remove all the RFC requirements from this prose and make the whole section an informative Note to explain what happened.

@jongund
Copy link
Contributor

jongund commented Apr 3, 2020

I think this a pretty big change to make combobox work, so I support the additional information on conformance checking and authors in ARIA 1.2, once there is wide spread implementation of the 1.2 combobox pattern and it works with AT this information can be removed from the spec in future versions of ARIA.

@jongund
Copy link
Contributor

jongund commented Apr 3, 2020

I think this a pretty big change to make combobox work, so I support the additional information on conformance checking and authors in ARIA 1.2.

Once there is wide spread implementation of the 1.2 combobox pattern and it works with AT this information can be removed from the spec in future versions.

@mcking65
Copy link
Contributor Author

@cookiecrook, I have revised the information about previous versions of combobox to be entirely informative.

Copy link
Contributor

@jongund jongund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much simpler than before, I miss some of the additional guidance that was there before, but not enough to request changes.

Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Looks good!

@jnurthen jnurthen merged commit 484af4e into master Apr 28, 2020
carmacleod pushed a commit that referenced this pull request May 7, 2020
…e 1178 (#1223)

* Revise UA, AT, and checker guidance per agreed text in issue 1178
* Remove normative requirements related to ARIA 1.0 and ARIA 1.1 patterns as suggested by @cookiecrook
* described in -> defined by
@jnurthen jnurthen deleted the issue1178 branch July 23, 2020 22:27
jnurthen pushed a commit that referenced this pull request Sep 9, 2020
…e 1178 (#1223)

* Revise UA, AT, and checker guidance per agreed text in issue 1178
* Remove normative requirements related to ARIA 1.0 and ARIA 1.1 patterns as suggested by @cookiecrook
* described in -> defined by
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UA requirements for ARIA 1.1 under combobox
5 participants