-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combobox: Revise UA, AT, and checker guidance per agreed text in issue 1178 #1223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, it covers conformance checking and assistive technology implementation issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something that can be addressed in the APG rather than in the spec? This new edit feels like an informative note, but it's written in formal RFC-2119 prose. For example, the advice to user agents to continue to make the legacy pattern work is not something that should be a formal requirement of the specification.
The conformance checkers statement seems out of place, too. The term SHOULD (not MAY) requires conformance checkers to recognize a complex-and-deprecated usage pattern documented elsewhere, rather than a concrete pattern (warn if specific markup is thus).
Even the author requirement is out of place, IMO: "Authors SHOULD convert implementations of the ARIA 1.1 pattern to the ARIA 1.2 pattern."
It should be concrete or not there at all. I'd rather the paragraph be deleted entirely from the spec.
Alternately, remove all the RFC requirements from this prose and make the whole section an informative Note to explain what happened. |
I think this a pretty big change to make combobox work, so I support the additional information on conformance checking and authors in ARIA 1.2, once there is wide spread implementation of the 1.2 combobox pattern and it works with AT this information can be removed from the spec in future versions of ARIA. |
I think this a pretty big change to make combobox work, so I support the additional information on conformance checking and authors in ARIA 1.2. Once there is wide spread implementation of the 1.2 combobox pattern and it works with AT this information can be removed from the spec in future versions. |
@cookiecrook, I have revised the information about previous versions of combobox to be entirely informative. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much simpler than before, I miss some of the additional guidance that was there before, but not enough to request changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Looks good!
…e 1178 (#1223) * Revise UA, AT, and checker guidance per agreed text in issue 1178 * Remove normative requirements related to ARIA 1.0 and ARIA 1.1 patterns as suggested by @cookiecrook * described in -> defined by
…e 1178 (#1223) * Revise UA, AT, and checker guidance per agreed text in issue 1178 * Remove normative requirements related to ARIA 1.0 and ARIA 1.1 patterns as suggested by @cookiecrook * described in -> defined by
Fixes #1178
Preview | Diff