Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add local abstract role usage warnings. fixes #1428 #1445

Merged
merged 2 commits into from May 6, 2021

Conversation

jorycunningham
Copy link
Contributor

@jorycunningham jorycunningham commented Apr 1, 2021

Fixes #1428

  • Adding in "Authors MUST NOT use {role name} role in content." language to each role description.
  • Remove class="note" from the paragraphs which contain the above statement
  • Moving this statement closer to the beginning of the description for longer descriptions.

馃挜 Error: 500 Internal Server Error 馃挜

PR Preview failed to build. (Last tried on Apr 8, 2021, 7:55 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

馃毃 HTML Diff Service - The HTML Diff Service is used to create HTML diffs of the spec changes suggested in a pull request.

馃敆 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 sysreq@w3.org to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just needs the old sentence in landmark role removed, and it's good to go!
Thanks, @jorycunningham !

index.html Outdated Show resolved Hide resolved
Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jorycunningham !
Looks good !

@carmacleod
Copy link
Contributor

(By the way, don't worry about PR Preview failing... it fails a lot).

@jnurthen jnurthen merged commit 3ebb415 into main May 6, 2021
jnurthen pushed a commit that referenced this pull request May 6, 2021
* add local abstract role usage warnings. fixes #1428
Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make it clearer that authors should not use abstract roles
5 participants