aria-disabled and descendant elements #1467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottaohara
commented
Jun 1, 2021
cookiecrook
previously approved these changes
Jul 1, 2021
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
smhigley
reviewed
Dec 6, 2021
In looking to address Sarah's comment, and re-reviewing the initial issue, I think I missed the mark on what needed to be called out here. So, this revision is an attempt to simplify/clarify what I was trying to say before (that a link should not inherit the disabled state from a parent element). This also removes the word "focusable" , as per the original issue a `<div role=textbox>` should still be communicated as being in the disabled state if a descendant of a `role=group aria-disabled=true`. Note: that the alternative here is to instead move forward with Aaron's issue #1632, and remove the allowance for a `group` to be marked as disabled. The caveat I see here is that since `group` is allowed in a `listbox` and `menu`, a `group` should probably still be allowed to be marked as disabled in these contexts... so that's tricky.
scottaohara
dismissed
cookiecrook鈥檚 stale review
PR has changed quite a bit since this review, so it should be reviwed again
|
Lets agenda+ this as I'm totally confused as to why we would want to prevent |
|
Resolution from today's meeting. close this PR. instead resolve to make a new PR that deprecates |
|
Notes from meeting: https://www.w3.org/2022/08/11-aria-minutes#t07 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some draft wording I have in place on how to resolve #1130.
Essentially, I do not want to break expectations with how
<fieldset disabled>works compared to<div role=group aria-disabled=true>in regards to nested links. In the former links are not disabled because HTML does not allow<a href>to be set to the disabled state. The latter will expose an<a href>or a<div role=link>as being in the disabled state. This should not happen and user agents that presently do this are likely not matching the reality of what the HTML author expected would happen.So, yeh. Happy to get feedback on what I've done so far and make adjustments as need be. But, am quite against the idea of the disabled state on an ancestor element impacting descendant links. So whatever we do here, I want to make sure that is clearly not what is expected here, unless it can be very clear this would only apply to
role=linkand NOT<a href>HTML links.Preview | Diff
馃挜 Error: 504 Gateway Timeout 馃挜
PR Preview failed to build. (Last tried on May 5, 2022, 12:47 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
馃毃 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
馃敆 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.