Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bullet 3 of name calc #1475

Merged
merged 1 commit into from May 6, 2021
Merged

update bullet 3 of name calc #1475

merged 1 commit into from May 6, 2021

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Apr 29, 2021

updates name calculation bullet 3 to state:

“the element does not support name from author”

rather than “the element has no name”

related to #1449


Preview | Diff

updates name calculation bullet 3 to state:

“the element does not support name from author”

rather than “the element has no name”
Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Perfect. :)
Thanks @scottaohara !

Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the quick PR

Copy link
Contributor

@joanmarie joanmarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1000

@jnurthen jnurthen merged commit e68a7ff into main May 6, 2021
jnurthen pushed a commit that referenced this pull request May 6, 2021
updates name calculation bullet 3 to state:
“the element does not support name from author”
rather than “the element has no name”
jnurthen pushed a commit that referenced this pull request May 6, 2021
updates name calculation bullet 3 to state:
“the element does not support name from author”
rather than “the element has no name”
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants