Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aria-level from listitem #1484

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Remove aria-level from listitem #1484

merged 1 commit into from
Jul 2, 2021

Conversation

WilliamTennisNFCU
Copy link
Contributor

@WilliamTennisNFCU WilliamTennisNFCU commented May 13, 2021 •
edited by pr-preview bot
Loading

Creating a draft pull request to log work completed. I'm not sure if there is more that needs to be done, so I wanted to have this reviewed.

  • Marked aria-level deprecated true on roleInfo.js for listitem role
  • Updated documentation to note that this is deprecated in 1.3

Preview | Diff

@WilliamTennisNFCU
Copy link
Contributor Author

@jnurthen I have created the PR from the fork here as a draft.

@a11ydoer
Copy link
Contributor

Congratulations on your first PR, @WilliamTennisNFCU !

@WilliamTennisNFCU WilliamTennisNFCU force-pushed the Issue/1369_Deprecate_aria-level_on_role_listitem branch from 654b103 to 740202d Compare June 11, 2021 00:00
@WilliamTennisNFCU WilliamTennisNFCU changed the title Deprecate aria-level on listitem Remove aria-level from listitem Jun 11, 2021
@WilliamTennisNFCU WilliamTennisNFCU marked this pull request as ready for review June 11, 2021 00:07
@jnurthen jnurthen requested review from scottaohara and removed request for carmacleod July 1, 2021 17:40
cookiecrook
cookiecrook approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your first approved PR, @WilliamTennisNFCU

@jnurthen jnurthen merged commit 7f72832 into w3c:main Jul 2, 2021
@jnurthen
Copy link
Member

jnurthen commented Jul 2, 2021

closes #1369

jnurthen pushed a commit that referenced this pull request Jul 2, 2021
@WilliamTennisNFCU @jnurthen
Remove aria-level attribute from listitem (#1484)
6cb563f
@eps1lon eps1lon mentioned this pull request Aug 25, 2021
Closed
@pkra pkra added this to the ARIA 1.3 milestone Jan 12, 2022
@pkra pkra mentioned this pull request Jan 12, 2022
Open
@pkra pkra mentioned this pull request Jun 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cookiecrook cookiecrook cookiecrook approved these changes

@jnurthen jnurthen jnurthen approved these changes

@scottaohara scottaohara scottaohara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@WilliamTennisNFCU @a11ydoer @jnurthen @cookiecrook @scottaohara @pkra