-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aria-errormessage is hidden or removed when not pertinent #1588
Conversation
b64114e
to
8328b20
Compare
I just fixed the conflict in the README and added a json file for the AXE results. It seems to me there is a bug in AXE, but I'm having trouble reporting it... Here are the results:
According to Jon's examples, inputs 1 - 4 should fail, and 5 - 8 should not, so the AXE results do not match the expectation. The more detailed error says edit: I wrote up a bug: dequelabs/axe-core-npm#328 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this PR but I also added a AXE file, so @joanmarie or @schne324 should take a look too.
ping @joanmarie @jnurthen This testcase resolves #1576 (which is technically in the 1.2 milestone). |
{ | ||
"description": "Ensures all ARIA attributes have valid values", | ||
"help": "ARIA attributes must conform to valid values", | ||
"helpUrl": "https://dequeuniversity.com/rules/axe/4.3/aria-valid-attr-value?application=webdriverjs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question, non-blocker: Is the query param needed here? It seems like the URL is valid without it. Just curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the file retrieved from aXe. I don't think we should be changing it.
|
||
<!-- | ||
URL: https://www.w3.org/TR/wai-aria-1.2/#aria-errormessage | ||
RULE: " Authors MUST use aria-invalid in conjunction with aria-errormessage and when aria-errormessage is pertinent, authors MUST ensure the content is not hidden so users can navigate to and examine the error message" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question, potential blocker: Should an example be included that has no aria-invalid
attribute?
From the spec, emphasis mine:
Initially, the object is in a valid state and either has aria-invalid set to false or no aria-invalid attribute, and the element referenced by aria-errormessage is not applicable.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would if this were a test file for all of aria-errormessage.
However this is only a testfile for the added authors MUST statements in aria 1.2. Without aria-invalid, aria-errormessage is not pertinent so the entire sentence would not apply.
@jnurthen can we merge this? It's actually closing the last open issue for the 1.2 milestone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
@spectranaut, you probably have already seen this but it looks like the underlying axe-core issue you raised has been resolved: dequelabs/axe-core#3149
Co-authored-by: Valerie Young <spectranaut@igalia.com> Co-authored-by: James Nurthen <jnurthen@users.noreply.github.com>
No description provided.