aria-errormessage is hidden or removed when not pertinent

[jongund]

No description provided.

[spectranaut]

I just fixed the conflict in the README and added a json file for the AXE results. It seems to me there is a bug in AXE, but I'm having trouble reporting it...

Here are the results:

  Violation of "aria-valid-attr-value" with 4 occurrences!
    Ensures all ARIA attributes have valid values. Correct invalid elements at:
     - #input-1
     - #input-2
     - #input-3
     - #input-7
    For details, see: https://dequeuniversity.com/rules/axe/4.3/aria-valid-attr-value

According to Jon's examples, inputs 1 - 4 should fail, and 5 - 8 should not, so the AXE results do not match the expectation. The more detailed error says aria-errormessage value id-message-1 must use a technique to announce the message (e.g., aria-live, aria-describedby, role=alert, etc.),. Seems to me this is wrong, and there is an additional bug in that the hiddenness of the element pointed to by aria-errormessage is not reported?

edit: I wrote up a bug: dequelabs/axe-core-npm#328

[spectranaut]

I approve this PR but I also added a AXE file, so @joanmarie or @schne324 should take a look too.

[pkra]

ping @joanmarie @jnurthen

This testcase resolves #1576 (which is technically in the 1.2 milestone).

[MelSumner]

Question, non-blocker: Is the query param needed here? It seems like the URL is valid without it. Just curious.

[jnurthen]

This is the file retrieved from aXe. I don't think we should be changing it.

[MelSumner]

Question, potential blocker: Should an example be included that has no aria-invalid attribute?

From the spec, emphasis mine:

Initially, the object is in a valid state and either has aria-invalid set to false or no aria-invalid attribute, and the element referenced by aria-errormessage is not applicable.

WDYT?

[jnurthen]

I think we would if this were a test file for all of aria-errormessage.

However this is only a testfile for the added authors MUST statements in aria 1.2. Without aria-invalid, aria-errormessage is not pertinent so the entire sentence would not apply.

[pkra]

@jnurthen can we merge this? It's actually closing the last open issue for the 1.2 milestone.

[schne324]

looks good to me.

@spectranaut, you probably have already seen this but it looks like the underlying axe-core issue you raised has been resolved: dequelabs/axe-core#3149