remove overly prescriptive distinctions from aria-current values. #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imitation from aria-current values.
scottaohara
approved these changes
Dec 10, 2021
|
Note: I also removed overly prescriptive context limitations on the other values (e.g. location was limited to an "image" in a "flow chart"), so this is a little more than editorial. |
|
I'm glad you made that change... i personally never interpreted that bit about Was it really a normative limitation being set there? That might be a gap in my understanding on how normative declared examples are if they are not contained within notes or non-normative sections |
smhigley
approved these changes
Dec 16, 2021
carmacleod
reviewed
Dec 16, 2021
There was a problem hiding this comment.
2 comments (in suggestions below):
- I really do prefer "set of pages" in the first suggestion below, because "page-based process" feels overly prescriptive. ;)
- Just something to think about with "location" instead of "component" in the second suggestion below, but I think it's fine either way.
Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1656.
Preview | Diff
💥 Error: 504 Gateway Timeout 💥
PR Preview failed to build. (Last tried on Jun 24, 2022, 8:22 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.