Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposed rewording for the complementary landmark #1698

Merged
merged 4 commits into from Aug 30, 2022
Merged

proposed rewording for the complementary landmark #1698

merged 4 commits into from Aug 30, 2022

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Mar 4, 2022 •
edited by pr-preview bot

closes #1396

might need some more wordsmithing, but something to go on / talk about at least

Preview | Diff

@pkra pkra added this to the ARIA 1.3 milestone Mar 7, 2022
@pkra pkra assigned pkra and unassigned pkra Mar 7, 2022
jnurthen
jnurthen reviewed Mar 8, 2022
View reviewed changes
index.html Outdated Show resolved Hide resolved
scottaohara
scottaohara commented Mar 8, 2022
View reviewed changes
index.html Outdated Show resolved Hide resolved
scottaohara
scottaohara commented Mar 13, 2022
View reviewed changes
index.html Outdated Show resolved Hide resolved
MelSumner
MelSumner approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a bit of an improvement. 👍 :shipit:

@pkra
Copy link
Member

pkra commented Apr 29, 2022

ping @jnurthen

@jnurthen jnurthen merged commit 8ef7dde into main Aug 30, 2022
github-actions bot added a commit that referenced this pull request Aug 30, 2022
@scottaohara @github-actions
proposed rewording for the complementary landmark (#1698)
6f2f87b 
SHA: 8ef7dde
Reason: push, by @jnurthen

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@scottaohara
Copy link
Member Author

@jnurthen i guess this is what happens when PRs linger for a long time, as I forgot I even made this and in turn made #1778 the other day. Do we like one wording over the other? :(

jnurthen pushed a commit that referenced this pull request Oct 10, 2023
@scottaohara @jnurthen
proposed rewording for the complementary landmark (#1698)
d222bb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spectranaut spectranaut spectranaut approved these changes

@jnurthen jnurthen jnurthen approved these changes

@MelSumner MelSumner MelSumner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023
Development

Successfully merging this pull request may close these issues.

Discussion: aside vs complementary
5 participants
@scottaohara @pkra @spectranaut @jnurthen @MelSumner