Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update figure role #1705

Merged
merged 5 commits into from Sep 1, 2022
Merged

update figure role #1705

merged 5 commits into from Sep 1, 2022

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Mar 12, 2022

This PR requires #1703 be merged.


Preview | Diff

This PR requires #1703 be merged.
Copy link
Contributor

@chlane chlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that aria-label and aria-labelledby can be used to label a figure element

Copy link
Contributor

@charmarkk charmarkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, and editorial looks good.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Approved the related PR as well. 👍

@pkra pkra added this to the ARIA 1.3 milestone Apr 29, 2022
@pkra
Copy link
Member

pkra commented Apr 29, 2022

@smhigley is this one ok by you now?

@pkra
Copy link
Member

pkra commented Sep 1, 2022

@scottaohara would you be able to resolve the merge conflicts?

@scottaohara
Copy link
Member Author

@pkra done

@pkra pkra merged commit c625cb7 into main Sep 1, 2022
@pkra pkra deleted the scottaohara-figure-definition-updates branch September 1, 2022 19:21
pkra pushed a commit that referenced this pull request Sep 2, 2022
* update figure role
  This PR requires #1703 be merged.
* Update index.html
* revisions per sarah's review
* further updates to figure def
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
* update figure role
  This PR requires #1703 be merged.
* Update index.html
* revisions per sarah's review
* further updates to figure def
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants