Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a label to the combobox listbox example #1728

Merged
merged 1 commit into from
Apr 29, 2022
Merged

added a label to the combobox listbox example #1728

merged 1 commit into from
Apr 29, 2022

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Apr 21, 2022 •
edited by pr-preview bot
Loading

Added a label reference to the listbox in the combobox example, including adding an id attribute to the label element for reference by aria-labelledby.

This pull request replaces pull 1227.

Preview | Diff

@jongund jongund linked an issue Apr 21, 2022 that may be closed by this pull request
Combox example code is missing accessible name for the listbox #1725
Closed
@jongund
Copy link
Contributor Author

jongund commented Apr 21, 2022

@spectranaut
Hopefully this new branch fixes the problems with the other pull request related to labeling the listbox.

@pkra pkra added this to the ARIA 1.3 milestone Apr 22, 2022
@shirsha shirsha self-requested a review April 28, 2022 17:21
@pkra pkra merged commit 43b6a45 into main Apr 29, 2022
@pkra pkra deleted the listbox-label-example branch April 29, 2022 06:57
github-actions bot added a commit that referenced this pull request Apr 29, 2022
@jongund @github-actions
added a label to the combobox listbox example (#1728)
21cb2c8 
SHA: 43b6a45
Reason: push, by @pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pkra pushed a commit that referenced this pull request Jul 14, 2022
@jongund @pkra
added a label to the combobox listbox example (#1728)
844724f
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
@jongund @jnurthen
added a label to the combobox listbox example (#1728)
c2adaeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkra pkra pkra approved these changes

@schne324 schne324 schne324 approved these changes

@scottaohara scottaohara scottaohara approved these changes

@shirsha shirsha shirsha approved these changes

@spectranaut spectranaut Awaiting requested review from spectranaut

@jnurthen jnurthen Awaiting requested review from jnurthen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023
Development

Successfully merging this pull request may close these issues.

Combox example code is missing accessible name for the listbox
5 participants
@jongund @pkra @schne324 @scottaohara @shirsha