Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editorial changes for translatable attrs #1762

Merged
merged 2 commits into from
Aug 30, 2022
Merged

editorial changes for translatable attrs #1762

merged 2 commits into from
Aug 30, 2022

Conversation

cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook commented Jun 30, 2022 •
edited by pr-preview bot
Loading

Resolves #1761

Preview | Diff

@cookiecrook cookiecrook mentioned this pull request Jun 30, 2022
Closed
@scottaohara scottaohara self-requested a review July 7, 2022 17:23
spectranaut
spectranaut approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

scottaohara
scottaohara reviewed Jul 7, 2022
View reviewed changes
Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing I’m unsure of is if the html links are setup correctly? If they are, then the spec preview to links are broken.

Think we just need to double check the links. But other than that looks good

@pkra pkra self-assigned this Aug 25, 2022
@jnurthen jnurthen merged commit 06c3f3d into main Aug 30, 2022
github-actions bot added a commit that referenced this pull request Aug 30, 2022
@cookiecrook @github-actions
editorial changes for translatable attrs (#1762)
e8b4602 
SHA: 06c3f3d
Reason: push, by @jnurthen

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pkra pushed a commit that referenced this pull request Aug 31, 2022
@cookiecrook @pkra
editorial changes for translatable attrs (#1762)
ab2dc64 
* fix links to language and directionality
Co-authored-by: James Nurthen <jnurthen@users.noreply.github.com>
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
@cookiecrook @jnurthen
editorial changes for translatable attrs (#1762)
dff6693 
* fix links to language and directionality
Co-authored-by: James Nurthen <jnurthen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaohara scottaohara scottaohara left review comments

@spectranaut spectranaut spectranaut approved these changes

@jnurthen jnurthen jnurthen approved these changes

Assignees

@pkra pkra

Labels
merged to stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editorial changes for ‘Translatable Attributes’
5 participants
@cookiecrook @spectranaut @jnurthen @scottaohara @pkra