Editorial: Update hidden term definition to match accname and core-aam #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlane
approved these changes
Jan 19, 2023
MelSumner
approved these changes
Jan 31, 2023
|
@pkra, I'd like if an editor could take a look at this, if you have the time! |
adampage
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
Thanks for this clarification!
I recently encountered the ambiguity of “hidden” in #1839 and ended up relying on its current meaning as being hidden from all users. As soon as #1856 is merged, I’ll update my PR to use the newer, more explicit definition.
pkra
reviewed
Feb 3, 2023
|
Ok @pkra, thanks for those suggestions, I see what you mean. I ended up editing both definitions to be shorter with references -- can you take a second look? |
pkra
approved these changes
Feb 7, 2023
jnurthen
pushed a commit
that referenced
this pull request
Oct 10, 2023
#1856) Co-authored-by: Valerie Young <spectranaut@igalia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1159
I introduced a new term, "hidden from all users", to capture the original definition of hidden, and changed the definition of "hidden" to mean what is means in the accname specification.
The new definition of "hidden" also works in all cases where "hidden" is referenced in core-aam and the most of the aria spec. When necessary, I changed "hidden" to "hidden from all users" -- which is only in the tab panel definition.
Preview | Diff