Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria-level): update to specify only level 1-6 #1873

Merged
merged 5 commits into from Mar 3, 2023

Conversation

ariellalgilmore
Copy link
Contributor

@ariellalgilmore ariellalgilmore commented Feb 16, 2023

Closes #1050

Related APG Issue/PR: w3c/aria-practices#2620


Preview | Diff

@ariellalgilmore ariellalgilmore marked this pull request as draft February 16, 2023 19:41
@ariellalgilmore ariellalgilmore marked this pull request as ready for review February 16, 2023 20:19
@JAWS-test
Copy link
Contributor

It should be considered whether ARIA headings may also have a level greater than 6 and that AT that does not transmit this is faulty. So far, there are already some browser-screenreader combinations that correctly output a level greater than 6

index.html Outdated
@@ -12021,7 +12021,7 @@ <h2>Definitions of States and Properties (all aria-* attributes)</h2>
<pdef>aria-level</pdef>
<div class="property-description">
<p><a>Defines</a> the hierarchical level of an <a>element</a> within a structure.</p>
<p>This can be applied inside trees to tree items, to headings inside a document, to nested grids, nested tablists and to other structural items that may appear inside a container or participate in an ownership hierarchy. The value for <pref>aria-level</pref> is an integer greater than or equal to 1.</p>
<p>This can be applied inside trees to tree items, to headings inside a document, to nested grids, nested tablists and to other structural items that may appear inside a container or participate in an ownership hierarchy. The value for <pref>aria-level</pref> is an integer greater than or equal to 1. If <pref>aria-level</pref> is being used on an element with role <pref>heading</pref> then authors MUST set the value to an integer between 1 and 6.</p>
Copy link
Member

@pkra pkra Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the benefits of this change?

From the summary in #1050 (comment) it seems that levels 1-9 on headings are widely supported in user agents, with only Chrome not supporting higher integer values (properly). Similarly only JAWS appears to be failing with levels above 6 while Talkback struggles slightly with levels 7-9.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkra my thoughts on this change were that as of right now all UA and AT support 1-6 and unless we suggest all UA and AT to support 1-9 then at the moment to ensure authors using aria-level with role heading are getting the expected experience across all UA and AT then they should use 1-6

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying. That sounds like good authoring advice (like your APG issue w3c/aria-practices#2620). From a spec perspective, it looks like pretty good support (especially with Chrome and JAWS looking like bugs), so I personally would rather file issues with user agents and AT instead of this change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tend to agree. While I’m not itching to use heading level 8s anytime soon, I’m not sure why the spec should be so strict on that?

yes html only has up to level 6, but also, html doesn’t have buttons that natively convey a pressed state…

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pkra and @scottaohara for jumping in. Just want to confirm before moving forward. Does it make sense to update the spec to go to be integers from 1 and 9 and then open issues with UA and AT's so that they all support up to level 9?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariellalgilmore I would wait until the WG has a chance to look at the PR next week.

@spectranaut
Copy link
Contributor

Discussed at today's meeting: https://www.w3.org/2023/02/23-aria-minutes#t02

index.html Outdated Show resolved Hide resolved
Co-authored-by: Peter Krautzberger <p.krautzberger@gmail.com>
@pkra pkra requested a review from scottaohara March 2, 2023 18:22
@pkra pkra added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Mar 3, 2023
@pkra pkra merged commit af84654 into w3c:main Mar 3, 2023
1 check passed
github-actions bot added a commit that referenced this pull request Mar 3, 2023
SHA: af84654
Reason: push, by pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore ariellalgilmore deleted the fix/aria-level-1-6 branch March 3, 2023 16:54
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heading with aria-level > 6
6 participants