Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification for exposure of generic elements #1949

Merged
merged 2 commits into from Jul 25, 2023
Merged

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Jun 6, 2023

closes w3c/html-aam#489
closes #1829

reworded the last paragraph of the generic definition to indicate that it can be ignored when not providing information important to the a11y tree, but if it does provide such information, then the generic element should be exposed.


Preview | Diff

closes w3c/html-aam#489

reworded the last paragraph of the generic definition to indicate that it can be ignored when not providing information important to the a11y tree, but if it does provide such information, then the generic element should be exposed.
@pkra pkra added the clarification clarifying or correcting language that is either confusing, misleading or under-specified label Jun 6, 2023
@pkra pkra added this to the ARIA 1.3 milestone Jun 6, 2023
@jnurthen jnurthen requested review from jnurthen, adampage and benbeaudry and removed request for jnurthen June 8, 2023 17:14
Copy link

@benbeaudry benbeaudry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great clarification. LGTM.

Copy link
Member

@adampage adampage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto. 🚀

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a normative statement, I think it should be more specific. I provided a suggestion.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@mcking65
Copy link
Contributor

Thank you @scottaohara. I think it's good to ship now.

@scottaohara
Copy link
Member Author

@jnurthen @spectranaut ready for merge when you are.

@pkra pkra merged commit dc19188 into main Jul 25, 2023
5 checks passed
@pkra pkra deleted the generic-clarification branch July 25, 2023 15:22
github-actions bot added a commit that referenced this pull request Jul 27, 2023
SHA: dc19188
Reason: push, by pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
closes w3c/html-aam#489
closes #1829

reworded the last paragraph of the generic definition to indicate that it can be ignored when not providing information important to the a11y tree, but if it does provide such information, then the generic element should be exposed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification clarifying or correcting language that is either confusing, misleading or under-specified
Projects
None yet
5 participants