-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Move accessibility relationship definitions to accessibility tree section #1989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so excellent. The new language and the relocation to the Accessibility Tree section makes this all much, much clearer to me. I also like how you leveraged the existing “excluded from the accessibility tree” language to avoid over-specifying/redefining anything there.
Co-authored-by: Adam Page <adamfpage@gmail.com>
Co-authored-by: Adam Page <adamfpage@gmail.com>
Co-authored-by: Adam Page <adamfpage@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this work, valerie.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @spectranaut. One more suggestion came up for me when I read the last batch of changes, but I’m also wandering into the minutiae. 😅 Besides that, this is all crystal clear to me. 🚀
Co-authored-by: Adam Page <adamfpage@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like it! I just left a couple minor suggestions completely up to your discretion (genuinely, feel free to ignore these, I'm on the fence on whether they're helpful or add too much cruft/boggy specifics)
index.html
Outdated
<section id="tree_relationships"> | ||
<h2>Relationships in the Accessibility Tree</h2> | ||
<p>The following terms are used to describe relationships between <abbr title="Document Object Model">DOM</abbr> elements.</p> | ||
<p>The <dfn data-export="" data-lt="accessibility child|owned child|child element|child|children|child elements">accessibility children</dfn> of a DOM element are all of the children of that element's corresponding <a>accessible object</a> in the <a>accessibility tree</a>. In terms of the DOM, that includes the following:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this sentence, it's a really good, clear summary 😊
<pre class="example highlight"> | ||
<div role="list"> | ||
<div role="listitem" aria-hidden="true">Excluded element</div> | ||
<div role="listitem" id="reparented">Reparented element</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div role="listitem" id="reparented">Reparented element</div> | |
<div role="listitem" id="reparented">Reparented element</div> | |
<div role="group"> | |
<div role="listitem">Descendent with non-generic intervening element</div> | |
</div> |
How do you feel about clarifying the non-generic-intervening element thing as well? (I know group
isn't technically an allowed child, so it's maybe a slightly weird example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm that is a good point... but I feel like I would want a separate example for that. Because in this example it says (for simplicity) this list item has no accessibility children. We could have an example with an "accessibility child" that has the wrong role so makes the markup invalid, but idk, seems weird to introduce an "invalid" example here!
…ty tree section (#1989) And add examples, follow up from the 2023 ARIA F2F discussion.
Ok, now, I'm trying something different! This replaces: #1965
Closes #1930
Attempt to add examples and more clarify to the definition of "accessibility child" and "accessibility parent" and add "accessibility descendant".
Preview | Diff