Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Move accessibility relationship definitions to accessibility tree section #1989

Merged
merged 11 commits into from
Aug 23, 2023

Conversation

spectranaut
Copy link
Contributor

@spectranaut spectranaut commented Jul 29, 2023

Ok, now, I'm trying something different! This replaces: #1965

Closes #1930

Attempt to add examples and more clarify to the definition of "accessibility child" and "accessibility parent" and add "accessibility descendant".


Preview | Diff

@spectranaut spectranaut assigned adampage and smhigley and unassigned adampage and smhigley Jul 29, 2023
@spectranaut spectranaut assigned adampage and unassigned adampage Jul 29, 2023
@pkra pkra self-requested a review July 29, 2023 16:52
Copy link
Member

@adampage adampage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so excellent. The new language and the relocation to the Accessibility Tree section makes this all much, much clearer to me. I also like how you leveraged the existing “excluded from the accessibility tree” language to avoid over-specifying/redefining anything there.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
spectranaut and others added 4 commits July 31, 2023 08:27
Co-authored-by: Adam Page <adamfpage@gmail.com>
Co-authored-by: Adam Page <adamfpage@gmail.com>
Co-authored-by: Adam Page <adamfpage@gmail.com>
@spectranaut spectranaut marked this pull request as ready for review August 3, 2023 21:04
@pkra pkra added this to the ARIA 1.3 milestone Aug 8, 2023
@spectranaut spectranaut changed the title Move accessibility relationship definitions to accessibility tree section Editorial: Move accessibility relationship definitions to accessibility tree section Aug 8, 2023
@spectranaut
Copy link
Contributor Author

@pkra can you take a look at this? and @adampage can you re-review now that I've addressed your comments?

Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this work, valerie.

Copy link
Member

@adampage adampage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @spectranaut. One more suggestion came up for me when I read the last batch of changes, but I’m also wandering into the minutiae. 😅 Besides that, this is all crystal clear to me. 🚀

index.html Outdated Show resolved Hide resolved
Co-authored-by: Adam Page <adamfpage@gmail.com>
Copy link
Contributor

@smhigley smhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like it! I just left a couple minor suggestions completely up to your discretion (genuinely, feel free to ignore these, I'm on the fence on whether they're helpful or add too much cruft/boggy specifics)

index.html Outdated
<section id="tree_relationships">
<h2>Relationships in the Accessibility Tree</h2>
<p>The following terms are used to describe relationships between <abbr title="Document Object Model">DOM</abbr> elements.</p>
<p>The <dfn data-export="" data-lt="accessibility child|owned child|child element|child|children|child elements">accessibility children</dfn> of a DOM element are all of the children of that element's corresponding <a>accessible object</a> in the <a>accessibility tree</a>. In terms of the DOM, that includes the following:</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this sentence, it's a really good, clear summary 😊

index.html Show resolved Hide resolved
<pre class="example highlight">
&lt;div role="list"&gt;
&lt;div role="listitem" aria-hidden="true"&gt;Excluded element&lt;/div&gt;
&lt;div role="listitem" id="reparented"&gt;Reparented element&lt;/div&gt;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&lt;div role="listitem" id="reparented"&gt;Reparented element&lt;/div&gt;
&lt;div role="listitem" id="reparented"&gt;Reparented element&lt;/div&gt;
&lt;div role="group"&gt;
&lt;div role="listitem"&gt;Descendent with non-generic intervening element&lt;/div&gt;
&lt;/div&gt;

How do you feel about clarifying the non-generic-intervening element thing as well? (I know group isn't technically an allowed child, so it's maybe a slightly weird example)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm that is a good point... but I feel like I would want a separate example for that. Because in this example it says (for simplicity) this list item has no accessibility children. We could have an example with an "accessibility child" that has the wrong role so makes the markup invalid, but idk, seems weird to introduce an "invalid" example here!

@spectranaut spectranaut merged commit bf10d80 into main Aug 23, 2023
3 checks passed
github-actions bot added a commit that referenced this pull request Aug 23, 2023
…ty tree section (#1989)

SHA: bf10d80
Reason: push, by spectranaut

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
…ty tree section (#1989)

And add examples, follow up from the 2023 ARIA F2F discussion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility Parent/Child follow ups
5 participants