Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: In favor of "owned element" and "owning element", uses "accessibility parent", "accessibility child" and "accessibility descendant" #2010

Merged
merged 7 commits into from
Nov 6, 2023

Conversation

spectranaut
Copy link
Contributor

@spectranaut spectranaut commented Aug 23, 2023

Closes #1150

As discussed in the F2F, "owned" elements refers to either descendant or the direct accessibility child. Also, using "owned" in this way is confusing, because it is not exactly the same as "aria-owns".


Preview | Diff

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Member

@pkra pkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but I'd also be ok with it as is.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
<p> Authors MUST ensure that one of the following two sets of conditions is met when setting the value of <code>aria-activedescendant</code> on an element with DOM focus:</p>
<ol>
<li>The value of <code>aria-activedescendant</code> refers to an [=ARIA/owned=] element. An owned element is either a descendant of the element with DOM focus or a logical descendant as indicated by the <pref>aria-owns</pref> attribute.</li>
<li>The value of <code>aria-activedescendant</code> refers to an <a>accessibility descendant</a>.</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@pkra
Copy link
Member

pkra commented Aug 29, 2023

@spectranaut one more observation which I can't link to another way:

The characteristics table for aria-expanded has

"The grouping element this element owns or controls is collapsed."

and

"The grouping element this element owns or controls is expanded."

Should these uses of "owns" be adjusted?

@pkra pkra added this to the ARIA 1.3 milestone Aug 29, 2023
spectranaut and others added 3 commits August 29, 2023 08:03
Co-authored-by: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com>
Co-authored-by: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com>
Co-authored-by: Peter Krautzberger <p.krautzberger@gmail.com>
@spectranaut
Copy link
Contributor Author

done! thanks

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@spectranaut
Copy link
Contributor Author

maybe we can merge this @pkra ?

@spectranaut spectranaut changed the title In favor of "owned element" and "owning element", uses "accessibility parent", "accessibility child" and "accessibility descendant" Editorial: In favor of "owned element" and "owning element", uses "accessibility parent", "accessibility child" and "accessibility descendant" Nov 6, 2023
@pkra pkra merged commit bb6baf1 into main Nov 6, 2023
5 checks passed
@pkra pkra deleted the new-replace-owns branch November 6, 2023 14:10
github-actions bot added a commit to pkra/aria that referenced this pull request Nov 10, 2023
…cessibility parent", "accessibility child" and "accessibility descendant" (w3c#2010)

SHA: bb6baf1
Reason: push, by pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear use of the term "descendant"
4 participants