-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: add <menu>
to list
role
#2023
Conversation
this is correct. i recall saying this should be added the past, but it was mentioned that might be confusing due to the menu role (and tbh it is) - and that related concepts don't necessarily have to list all related concepts. so, stopping short of approving until others weigh in on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
@pkra @spectranaut seems this can be marked as non-substantive and merged? |
@scottaohara I personally found your argument in #2023 (comment) convincing to not do this. But I do not feel strongly about this at all. |
@spectranaut @jnurthen what do you think about Scott's point? |
well to be clear, it's more me relaying the point others made to me in the past about this. i don't much mind one way or the other if this is merged. but it seemed like it was going that route since reviewers were assigned and approved the addition. edit: per your commenting in older issues/PRs today, @pkra, you inadvertently(?) resurfaced the PR that i had originally called out adding |
hah, that was not intentional. FWIW, I feel the same way as @jnurthen in the other PR:
|
Thank you for the PR but closing this as there is no consensus that this makes the spec less confusing. |
From the Living Standard:
According to ARIA in HTML, its implicit role is
list
.Preview | Diff