Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: add <menu> to list role #2023

Closed
wants to merge 1 commit into from
Closed

Editorial: add <menu> to list role #2023

wants to merge 1 commit into from

Conversation

imageck
Copy link

@imageck imageck commented Aug 31, 2023

From the Living Standard:

The menu element is simply a semantic alternative to ul to express an unordered list of commands (a "toolbar").

According to ARIA in HTML, its implicit role is list.


Preview | Diff

@scottaohara
Copy link
Member

this is correct.

i recall saying this should be added the past, but it was mentioned that might be confusing due to the menu role (and tbh it is) - and that related concepts don't necessarily have to list all related concepts. so, stopping short of approving until others weigh in on this.

Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! 👍

@pkra pkra added this to the ARIA 1.3 milestone Sep 2, 2023
Copy link
Contributor

@rahimabdi rahimabdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@scottaohara
Copy link
Member

@pkra @spectranaut seems this can be marked as non-substantive and merged?

@pkra pkra added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Feb 6, 2024
@pkra
Copy link
Member

pkra commented Feb 6, 2024

@scottaohara I personally found your argument in #2023 (comment) convincing to not do this. But I do not feel strongly about this at all.

@pkra
Copy link
Member

pkra commented Feb 7, 2024

@spectranaut @jnurthen what do you think about Scott's point?

@scottaohara
Copy link
Member

scottaohara commented Feb 7, 2024

well to be clear, it's more me relaying the point others made to me in the past about this.

i don't much mind one way or the other if this is merged. but it seemed like it was going that route since reviewers were assigned and approved the addition.

edit: per your commenting in older issues/PRs today, @pkra, you inadvertently(?) resurfaced the PR that i had originally called out adding <menu> where @jnurthen noted he didn't see the value - #1740 (comment)

@pkra
Copy link
Member

pkra commented Feb 8, 2024

edit: per your commenting in older issues/PRs today, @pkra, you inadvertently(?) resurfaced the PR that i had originally called out adding

where @jnurthen noted he didn't see the value - #1740 (comment)

hah, that was not intentional.

FWIW, I feel the same way as @jnurthen in the other PR:

I don't think it makes the spec any more understandable though as most devs would probably mistake the menu element for something useful

@jnurthen
Copy link
Member

jnurthen commented May 2, 2024

Thank you for the PR but closing this as there is no consensus that this makes the spec less confusing.
If you feel that this should be reconsidered please file an issue so we can discuss with the group.

@jnurthen jnurthen closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants