Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created new entry: "focusable". #2066

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MarioBatusic
Copy link
Contributor

Closes #1936

Crated a minimal entry with a link to the definition in the HTML Spec.

I crated a minimal entry with a link to the definition in the HTML Spec.
@MarioBatusic MarioBatusic linked an issue Oct 19, 2023 that may be closed by this pull request
</dd>
<dt><dfn>Focusable</dfn></dt>
<dd>
<p>An element or an area in a document is focusable, if it can get the system focus. In different circumstances one can use one or more of following methods to set focus:</p>
Copy link
Contributor

@rahimabdi rahimabdi Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remain consistent with other spec references to "focus", I would suggest "receive focus" rather than "get". For examples where focus is referenced:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that verb is better here. Thanks.

Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current PR doesn't include a lot of the items discussed as necessary in the original PR attempt: w3c/aria-common#39

In particular, this comment and follow-on disucssion w3c/aria-common#39 (comment)

Also, I recall we had discussed pointing to an external definition (HTML?) instead of defining one in ARIA, but if something does land here, it should reference pointers rather than modality-specific concepts (mouse/touch/etc).

Comment on lines 85 to 92
<p>An element or an area in a document is focusable, if it can receive focus. In different circumstances one can use one or more of the following methods to set focus:</p>
<ul>
<li>by scripting</li>
<li>using a mouse</li>
<li>using keyboard</li>
<li>by touch.</li>
</ul>
<p>For a detailed description see <a href="https://html.spec.whatwg.org/#focusable-area">Focusable area</a> in the HTML Specification.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>An element or an area in a document is focusable, if it can receive focus. In different circumstances one can use one or more of the following methods to set focus:</p>
<ul>
<li>by scripting</li>
<li>using a mouse</li>
<li>using keyboard</li>
<li>by touch.</li>
</ul>
<p>For a detailed description see <a href="https://html.spec.whatwg.org/#focusable-area">Focusable area</a> in the HTML Specification.</p>
<p>An element or area matching the definition of <a href="https://html.spec.whatwg.org/#focusable-area">focusable area</a> in the HTML Specification.</p>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replying to @MarioBatusic's email response question with a specific edit suggestion. If the term is to be defined in ARIA, it should be a direct cross-reference to the other spec's definition, rather than a terse-but-incomplete variant.

Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@MarioBatusic
Copy link
Contributor Author

@cookiecrook Thanx for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do we need a focusable definition
3 participants