[core-aam PR 230] Update aria-labelledby AXAPI mapping to use AXTitle #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Include co-author when merging. |
13 tasks
spectranaut
requested changes
May 28, 2024
There was a problem hiding this comment.
Hi Rahim, this PRs has been moved, so please continue the work here :)
I have a few questions/comments for you:
- This looks good, but from the issue, it looks like
aria-labelis updated toAXTitleas well, where you doing that in a separate PR? Seems to me like it could be done here as well. - Can you confirm whether there will need to be a change in firefox and chrome? Seems like it! if so we need to track those implementations.
pkra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies w3c/core-aam#230 by @rahimabdi
Closes w3c/core-aam#215