Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify keyshortcuts usage #487

Closed
wants to merge 1 commit into from
Closed

Clarify keyshortcuts usage #487

wants to merge 1 commit into from

Conversation

ZoeBijl
Copy link

@ZoeBijl ZoeBijl commented Nov 23, 2016

Was: Indicates keyboard shortcuts that an author has implemented to activate or give focus to an element.

Changed into: Indicates keyboard shortcuts that an author has implemented to activate or give focus to the currently focused element.

@mcking65 @accdc

Was: <q>Indicates keyboard shortcuts that an author has implemented to activate or give focus to an element.</q>

Changed into: <q>Indicates keyboard shortcuts that an author has implemented to activate or give focus to the currently focused element.</q>
@ZoeBijl
Copy link
Author

ZoeBijl commented Nov 23, 2016

Maybe “current element” instead of “currently focused element”?

@mcking65
Copy link
Contributor

The element does not have to be focused for the keyshortcut property to be present or useful. And, current element is not a defined term.

I think the definition is very good the way it is. The only thing I would consider tweaking is changing "an element" to "the element" so it is consistent with similar definitions and makes it clear that the element that has the property is the element that will be activated or focused when the shortcut is executed.

@ZoeBijl
Copy link
Author

ZoeBijl commented Nov 30, 2016

Entire line has been rewritten by someone, so closing this.

@ZoeBijl ZoeBijl closed this Nov 30, 2016
@ZoeBijl ZoeBijl deleted the keyshortcuts branch November 30, 2016 01:18
pkra pushed a commit that referenced this pull request May 20, 2024
Some aria-hidden links refer to WAI-ARIA 1.1, not 1.2.

Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants