Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row Role: allow aria-posinset and aria-setsize for issue 558 #789

Merged
merged 2 commits into from
Aug 21, 2018

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Jul 11, 2018

Modified text and properties of the role row for issue #558:

  • Removed paragraph about aria-expanded in treegrids.
  • Add paragraph with two normative statements:
    • Authors should only use setsize, posinset, level, and expanded attributes in treegrids
    • User agents should only expose them in treegrids
  • Modified allowed states and properties to allow aria-posinset and aria-setsize.

Preview | Diff

Modified text and properties of the role row for issue #558:
- Removed paragraph about aria-expanded in treegrids.
- Add paragraph with two normative statements:
  * Authors should only use setsize, posinset, level, and expanded attributes in treegrids
  * User agents should only expose them in treegrids
- Modified allowed states and properties to allow aria-posinset and aria-setsize.
index.html Outdated
<p>Rows contain <rref>cell</rref> or <rref>gridcell</rref> <a>elements</a>, and thus serve to organize a <rref>table</rref>, <rref>grid</rref>, or <rref>treegrid</rref>.</p>
<p>
While the row role can be used in <rref>tables</rref>, <rref>grids</rref>, and <rref>treegrids</rref>, the semantics of <sref>aria-expanded</sref>, <pref>aria-posinset</pref>, <pref>aria-setsize</pref>, and <pref>aria-level</pref> are only applicable to the hierarchical structure of an interactive treegrid.
Therefore, authors SHOULD NOT apply <sref>aria-expanded</sref>, <pref>aria-posinset</pref>, <pref>aria-setsize</pref>, and <pref>aria-level</pref> to a <rref>row</rref> that descends from a <rref>table</rref> or <rref>grid</rref>, and user agents SHOULD NOT expose any of these four properties to assistive technologies unless the <rref>row</rref> descends from a <rref>treegrid</rref>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this authors MUST NOT?

index.html Outdated
<p>In a <rref>treegrid</rref>, authors MAY mark rows as expandable, using the <sref>aria-expanded</sref> <a>attribute</a> to indicate the present status. This is not the case for an ordinary <rref>table</rref> or <rref>grid</rref>, in which the <sref>aria-expanded</sref> attribute is not present.</p>
<p>Rows contain <rref>cell</rref> or <rref>gridcell</rref> <a>elements</a>, and thus serve to organize a <rref>table</rref>, <rref>grid</rref>, or <rref>treegrid</rref>.</p>
<p>
While the row role can be used in <rref>tables</rref>, <rref>grids</rref>, and <rref>treegrids</rref>, the semantics of <sref>aria-expanded</sref>, <pref>aria-posinset</pref>, <pref>aria-setsize</pref>, and <pref>aria-level</pref> are only applicable to the hierarchical structure of an interactive treegrid.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the treegrid at the end of this sentence be an rref?

For issue #558, Make changes in response to feedback from @jnurthen and @carmacleod:
* Change author SHOULD NOT to MUST NOT use setsize, posinset, level, and expanded attributes in treegrids
* change treegrids to tree grids in one place where not referring specifically to the treegrid role.
@jnurthen jnurthen merged commit 7480350 into master Aug 21, 2018
joanmarie pushed a commit that referenced this pull request Sep 4, 2019
- Removed paragraph about aria-expanded in treegrids.
- Add paragraph with two normative statements:
  * Authors must only use setsize, posinset, level, and expanded
    attributes in treegrids
  * User agents should only expose them in treegrids
- Modified allowed states and properties to allow aria-posinset and
  aria-setsize.
@jnurthen jnurthen deleted the issue558-posinset-on-row branch July 23, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants