-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Row Role: allow aria-posinset and aria-setsize for issue 558 #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified text and properties of the role row for issue #558: - Removed paragraph about aria-expanded in treegrids. - Add paragraph with two normative statements: * Authors should only use setsize, posinset, level, and expanded attributes in treegrids * User agents should only expose them in treegrids - Modified allowed states and properties to allow aria-posinset and aria-setsize.
jnurthen
reviewed
Jul 11, 2018
index.html
Outdated
<p>Rows contain <rref>cell</rref> or <rref>gridcell</rref> <a>elements</a>, and thus serve to organize a <rref>table</rref>, <rref>grid</rref>, or <rref>treegrid</rref>.</p> | ||
<p> | ||
While the row role can be used in <rref>tables</rref>, <rref>grids</rref>, and <rref>treegrids</rref>, the semantics of <sref>aria-expanded</sref>, <pref>aria-posinset</pref>, <pref>aria-setsize</pref>, and <pref>aria-level</pref> are only applicable to the hierarchical structure of an interactive treegrid. | ||
Therefore, authors SHOULD NOT apply <sref>aria-expanded</sref>, <pref>aria-posinset</pref>, <pref>aria-setsize</pref>, and <pref>aria-level</pref> to a <rref>row</rref> that descends from a <rref>table</rref> or <rref>grid</rref>, and user agents SHOULD NOT expose any of these four properties to assistive technologies unless the <rref>row</rref> descends from a <rref>treegrid</rref>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't this authors MUST NOT?
carmacleod
reviewed
Aug 16, 2018
index.html
Outdated
<p>In a <rref>treegrid</rref>, authors MAY mark rows as expandable, using the <sref>aria-expanded</sref> <a>attribute</a> to indicate the present status. This is not the case for an ordinary <rref>table</rref> or <rref>grid</rref>, in which the <sref>aria-expanded</sref> attribute is not present.</p> | ||
<p>Rows contain <rref>cell</rref> or <rref>gridcell</rref> <a>elements</a>, and thus serve to organize a <rref>table</rref>, <rref>grid</rref>, or <rref>treegrid</rref>.</p> | ||
<p> | ||
While the row role can be used in <rref>tables</rref>, <rref>grids</rref>, and <rref>treegrids</rref>, the semantics of <sref>aria-expanded</sref>, <pref>aria-posinset</pref>, <pref>aria-setsize</pref>, and <pref>aria-level</pref> are only applicable to the hierarchical structure of an interactive treegrid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the treegrid at the end of this sentence be an rref?
For issue #558, Make changes in response to feedback from @jnurthen and @carmacleod: * Change author SHOULD NOT to MUST NOT use setsize, posinset, level, and expanded attributes in treegrids * change treegrids to tree grids in one place where not referring specifically to the treegrid role.
joanmarie
pushed a commit
that referenced
this pull request
Sep 4, 2019
- Removed paragraph about aria-expanded in treegrids. - Add paragraph with two normative statements: * Authors must only use setsize, posinset, level, and expanded attributes in treegrids * User agents should only expose them in treegrids - Modified allowed states and properties to allow aria-posinset and aria-setsize.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified text and properties of the role row for issue #558:
Preview | Diff