Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirement to strip OWS out of scope #58

Closed
dyladan opened this issue Apr 8, 2021 · 6 comments
Closed

Requirement to strip OWS out of scope #58

dyladan opened this issue Apr 8, 2021 · 6 comments

Comments

@dyladan
Copy link
Member

dyladan commented Apr 8, 2021

Currently the spec contains the following wording multiple times:

Leading and trailing whitespaces (OWS) are allowed but MUST be trimmed when converting the header into a data structure.

I believe this is beyond the scope of this specification. The specification should only refer to the expected wire-format of the data. How it is interpreted is up to the consumer and producer of the data.

@SergeyKanzhelev
Copy link
Member

I think what we need to do is to say that values MAY be trimmed or OWS-ed without the change of a semantic

@SergeyKanzhelev
Copy link
Member

same as http headers RFC does. We already refer to multi-value headers and they use this language, that appending and splitting values MUST Not change the semantic

@dyladan
Copy link
Member Author

dyladan commented Apr 9, 2021

Appending and splitting is different than parsing it into a data structure. Making restrictions on how a program represents the header in memory is too restrictive.

I agree that appending and splitting must not change the semantic, but that's not what the sentence is about.

@SergeyKanzhelev
Copy link
Member

we are in agreement. My comment was a suggestion on how to phrase what that sentence used to say better.

@dyladan
Copy link
Member Author

dyladan commented Apr 20, 2021

I actually think wording about splitting/joining multiple headers is different from "parsing into a data structure".

Requirements about the parsed data structure are out of scope for the wire protocol. We shouldn't care if they decide to represent it as a nested object, a string, or a hex encoded byte array as long as they serialize it in a standard compatible way.

@kalyanaj
Copy link
Contributor

Fixed by #87 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants