Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unenforceable requirement to strip whitespace #87

Merged
merged 2 commits into from Apr 12, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Mar 1, 2022

Requiring OWS to be stripped when the header is parsed into a data structure is unenforceable and unnecessarily prescriptive. This specification deals with the wire format, not the in-memory representation of the data it carries. OWS should either be allowed or not and the implementer can decide if it should be stripped.


Preview | Diff

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we cannot dictate the processing of the tokens, but I think the intention of those clauses was to say that whitespace is not part of the tokens. I.e. if I receive key=" abc" I am allowed to send it further as just key="abc", I am not required to preserve whitespace. Unless we say that elsewhere, I would suggest not removing the clauses but rewording them.

@dyladan
Copy link
Member Author

dyladan commented Mar 2, 2022

I agree that we cannot dictate the processing of the tokens, but I think the intention of those clauses was to say that whitespace is not part of the tokens. I.e. if I receive key=" abc" I am allowed to send it further as just key="abc", I am not required to preserve whitespace. Unless we say that elsewhere, I would suggest not removing the clauses but rewording them.

Updated PTAL

@dyladan dyladan merged commit ecdaa17 into w3c:main Apr 12, 2022
@dyladan dyladan deleted the do-not-require-strip-ows branch April 12, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants