Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

credentials "omit" needs to be changed updated #1

Closed
plehegar opened this issue Oct 8, 2014 · 5 comments
Closed

credentials "omit" needs to be changed updated #1

plehegar opened this issue Oct 8, 2014 · 5 comments
Assignees
Labels

Comments

@plehegar
Copy link
Member

plehegar commented Oct 8, 2014

[[
We should set the "Content-Type" header as an author header, and the "omit" credentials
mode" flag to "never" when invoking the fetch algorithm.
]]
http://lists.w3.org/Archives/Public/public-web-perf/2014Feb/0025.html

@sicking
Copy link

sicking commented Oct 8, 2014

I thought we had agreed to always send cookies with beacons?

@plehegar
Copy link
Member Author

plehegar commented Oct 8, 2014

The spec says "omit" at the moment, and Arvind was wondering about it:
[[
Re. the "credentials mode" parameter in the Fetch request, currently
we have it set to "omit". What should it be instead of that?
]]
http://lists.w3.org/Archives/Public/public-web-perf/2014Aug/0046.html

So, I guess the value needs to be "include", correct?

@plehegar plehegar changed the title credentials "omit" needs to be changed to "never" credentials "omit" needs to be changed updated Oct 8, 2014
@sicking
Copy link

sicking commented Oct 8, 2014

It should be "include" yes.

@plehegar
Copy link
Member Author

plehegar commented Oct 8, 2014

Thank you Jonas.
Arvind, I'm happy to make the change if you'd like me to.

@jainarvind
Copy link
Contributor

Thanks Jonas and Philippe. Please go ahead and make the change.

On Wed, Oct 8, 2014 at 3:50 PM, Philippe Le Hegaret <
notifications@github.com> wrote:

Thank you Jonas.
Arvind, I'm happy to make the change if you'd like me to.


Reply to this email directly or view it on GitHub
#1 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants