Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some content to the RTL/bidi text section #105

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Conversation

xfq
Copy link
Member

@xfq xfq commented Jun 9, 2023

@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for bp-i18n-specdev ready!

Name Link
🔨 Latest commit 8f01c2d
🔍 Latest deploy log https://app.netlify.com/sites/bp-i18n-specdev/deploys/6584584e1a7d1c0008f1915a
😎 Deploy Preview https://deploy-preview-105--bp-i18n-specdev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aphillips
Copy link
Contributor

Note: we discussed italics/obliquing in the I18N+CSS call on 2023-07-26.

index.html Outdated
</aside>

<div class="req" id="italics_left">
<p class="advisement">Specifications enabling italicization of text should support sloping the letters to the left.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably this should say "obliquing" instead of "italicization". I would suggest making this more generic as well. Perhaps:

Suggested change
<p class="advisement">Specifications enabling italicization of text should support sloping the letters to the left.</p>
<p class="advisement">Specifications enabling the italicization or obliquing of text SHOULD provide for characters to slope either to the right or to the left according to the needs of the specific language.</p>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you could just say:
Specifications that enable sloping of letterforms SHOULD...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have updated the PR.

@aphillips aphillips requested a review from r12a July 31, 2023 16:31
index.html Outdated Show resolved Hide resolved
Co-authored-by: Addison Phillips <addisonI18N@gmail.com>
@aphillips
Copy link
Contributor

Discussed in the 2023-12-21 teleconference and approved by the WG

@aphillips aphillips merged commit d7e8596 into gh-pages Dec 21, 2023
4 checks passed
@aphillips aphillips deleted the xfq/typ_bidi branch December 21, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants