Mirror tr-design changes and update specdev markup #113
Conversation
- Mirror the changes in tr-design - Change `span class="uname"` to `code class="uname"` globally
✅ Deploy Preview for bp-i18n-specdev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
One observation: should we recommend what to put into the Also... do we want to image-ize invisibles mentioned in specdev? ("this dog food is yummy") This PR changes |
|
I think they can probably figure out what they want to put in the alt text. Usually, if it's not an invisible character i put the character itself, but i'm not sure we need to recommend that. I agree that we should imagize the invisibles in specdev. |
|
I made a comment somewhere about recommending that authors style the bdi character(s) for font-family & font-size, which i imagine applies to these changes too. |
The list is not as short as one might like 😉 but I will pull one together. If you (@r12a) could generate the images, I'd appreciate it. I think I'll make a separate task out of that... |
| @@ -2359,7 +2359,7 @@ <h5>Character naming template</h5> | |||
|
|
|||
| <p>The <code translate="no" class="kw">bdi</code> element is used to ensure that example characters that are right-to-left do not interfere with the layout of the page. Do not include line breaks or a space between the closing <code translate="no" class="kw">bdi</code> and the following <code translate="no" class="kw">span</code> element; spacing and presentation is controlled by styling.</p> | |||
|
|
|||
| <p>The <code translate="no" class="kw">lang</code> attribute should be filled in appropriately to get the correct font selection for a given context. Examples in East Asian languages (such as Chinese, Japanese, or Korean) or in the Arabic script can sometimes require greater care in choosing a language tag. In some cases, it might also be necessary for you to adjust the <kbd translate="no">font-family</kbd> and/or <kbd translate="no">font-size</kbd> in your own style sheet for characters or character sequences in a given language.</p> | |||
| <p>The <code translate="no" class="kw">lang</code> attribute should be filled in appropriately to get the correct font selection for a given context. Examples in East Asian languages (such as Chinese, Japanese, or Korean) or in the Arabic script can sometimes require greater care in choosing a language tag. Rarely, for certain languages, it might be necessary to adjust the style of the <code>bdi</code> element with a <kbd translate="no">font-family</kbd> and/or <kbd translate="no">font-size</kbd> in your own stylesheet.</p> | |||
There was a problem hiding this comment.
I'm inclined to think that it's not nessecelery rare, most non-latin usages will probably need some styling.
There was a problem hiding this comment.
Most users will be dealing with ASCII and perhaps some specific characters, so this "rarely" is targeted at them (rather than at us).
|
I took one last look at the generated version. The proposed changes look ok. However, i noticed 2 things:
|
- merge subsection into section - move text as appropriate - make link to editing guidelines use the purple box instead of "see also" - additional edits for flow and usability resulting from the above
The mustard said "...code points in the specification", but it makes more sense to say "a specification" or perhaps "your specification". Span-to-code was because we changed the markup but not the text.
span class="uname"tocode class="uname"globallyPreview | Diff